Re: [Buildroot] [PATCH v2 3/3] package/systemd: add the missing superblock identifiers

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Stefan Berger <stefanb@linux.ibm.com>,
	James Hilliard <james.hilliard1@gmail.com>,
	Erik Larsson <karl.erik.larsson@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/3] package/systemd: add the missing superblock identifiers
Date: Thu, 6 Jun 2024 13:14:24 +0200	[thread overview]
Message-ID: <ZmGaEE7E0c2FzWpN@landeda> (raw)
In-Reply-To: <20240606104813.1514-4-jarkko@kernel.org>

Jarkko, All,

Sorry, I forgot something in the previous review...

On 2024-06-06 13:48 +0300, Jarkko Sakkinen spake thusly:
> The following superblock identifiers are missing:
> 1. BCACHEFS_SUPER_MAGIC
> 2. PID_FS_MAGIC
[--SNIP--]
> diff --git a/package/systemd/0001-basic-add-pidfs-magic-31709.patch b/package/systemd/0001-basic-add-pidfs-magic-31709.patch
> new file mode 100644
> index 0000000000..683f91dbb7
> --- /dev/null
> +++ b/package/systemd/0001-basic-add-pidfs-magic-31709.patch
> @@ -0,0 +1,50 @@
> +From 5cffe2484bbc6ec4b5b721094936f510a81c5167 Mon Sep 17 00:00:00 2001
> +From: cpackham-atlnz <85916201+cpackham-atlnz@users.noreply.github.com>
> +Date: Tue, 12 Mar 2024 00:55:36 +1300
> +Subject: [PATCH 1/2] basic: add PIDFS magic (#31709)
> +
> +Kernel commit cb12fd8e0dabb9a1c8aef55a6a41e2c255fcdf4b added pidfs.
> +Update filesystems-gperf.gperf and missing_magic.h accordingly.
> +
> +This fixes the following error building against a bleeding edge kernel.
> +```
> +../src/basic/meson.build:234:8: ERROR: Problem encountered: Unknown filesystems defined in kernel headers:
> +
> +Filesystem found in kernel header but not in filesystems-gperf.gperf: PID_FS_MAGIC
> +```

You forgot to add an "Upstream:" tag:

    https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation

Applicalble to both bundled patches.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot