Re: [GSoC][PATCH 5/6] t-reftable-pq: add test for index based comparison

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

On Thu, Jun 06, 2024 at 01:10:49PM +0530, Chandra Pratap wrote:
> diff --git a/t/unit-tests/t-reftable-pq.c b/t/unit-tests/t-reftable-pq.c
> index 30bf9cb492..6f6bf58307 100644
> --- a/t/unit-tests/t-reftable-pq.c
> +++ b/t/unit-tests/t-reftable-pq.c
> @@ -18,7 +18,7 @@ static void merged_iter_pqueue_check(const struct merged_iter_pqueue *pq)
>  	}
>  }
>  
> -static void test_pq(void)
> +static void test_pq_record(void)
>  {
>  	struct merged_iter_pqueue pq = { 0 };
>  	struct reftable_record recs[54];
> @@ -59,9 +59,49 @@ static void test_pq(void)
>  	merged_iter_pqueue_release(&pq);
>  }
>  
> +

Nit: there's an extraneous empty line here.

Other than that this patch looks good to me.

Patrick

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]