From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: testmgr - test setkey in no-SIMD context
Date: Fri, 7 Jun 2024 19:51:58 +0800 [thread overview]
Message-ID: <ZmL0XgXJKYnPBvJY@gondor.apana.org.au> (raw)
In-Reply-To: <20240527080539.163052-1-ebiggers@kernel.org>
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Since crypto_shash_setkey(), crypto_ahash_setkey(),
> crypto_skcipher_setkey(), and crypto_aead_setkey() apparently need to
> work in no-SIMD context on some architectures, make the self-tests cover
> this scenario. Specifically, sometimes do the setkey while under
> crypto_disable_simd_for_test(), and do this independently from disabling
> SIMD for the other parts of the crypto operation since there is no
> guarantee that all parts happen in the same context. (I.e., drivers
> mustn't store the key in different formats for SIMD vs. no-SIMD.)
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/testmgr.c | 29 ++++++++++++++++++++++++-----
> 1 file changed, 24 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-06-07 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 8:05 [PATCH] crypto: testmgr - test setkey in no-SIMD context Eric Biggers
2024-06-07 11:51 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmL0XgXJKYnPBvJY@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.