From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Avri Altman <Avri.Altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH] scsi: core: Remove an incorrect comment
Date: Fri, 7 Jun 2024 22:24:41 -0700 [thread overview]
Message-ID: <ZmPrGSJvofIjA2fb@infradead.org> (raw)
In-Reply-To: <20240607213553.1743087-1-bvanassche@acm.org>
On Fri, Jun 07, 2024 at 02:35:53PM -0700, Bart Van Assche wrote:
> The comment that scsi_static_device_list would go away was added more than
> 18 years ago. Today, that list is still there and 84 additional entries have
> been added. This shows that the comment is incorrect. Hence remove that
> comment.
I agree that the comment as-is is bogus. But it would be good to state
that quirks should go into the LLDs if they aren't for devices on a
physical bus like SAS, Fibre Channel or parallel SCSI. Most quirks
theses days are for unusually buggy consumer devices like UFS or
usb-storage/uas and are better placed there instead of in the core
scsi code.
next prev parent reply other threads:[~2024-06-08 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 21:35 [PATCH] scsi: core: Remove an incorrect comment Bart Van Assche
2024-06-08 5:24 ` Christoph Hellwig [this message]
2024-06-10 18:08 ` Bart Van Assche
2024-06-11 17:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmPrGSJvofIjA2fb@infradead.org \
--to=hch@infradead.org \
--cc=Avri.Altman@wdc.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.