From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Fernando Yang <hagisf@usp.br>
Cc: linux-iio@vger.kernel.org, Michael.Hennerich@analog.com,
jic23@kernel.org, lars@metafoo.de
Subject: Re: [PATCH v2 3/3] iio: adc: ad7266: Fix codestyle error
Date: Sat, 8 Jun 2024 02:29:08 -0300 [thread overview]
Message-ID: <ZmPsJH8k9ta100Ss@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <20240603180757.8560-3-hagisf@usp.br>
Looks good.
One minor neat being the last change won't be needed after patch 2 is updated.
Also, I think it will help visualize the patch series if a cover letter is added.
If running format-patch, the --cover-letter should help with it. e.g.
git format-patch -v3 --thread=shallow --cover-letter --to="..." --cc="..." -3
On 06/03, Fernando Yang wrote:
> Fix some codestyle errors indicated by checkpatch.pl
>
> Signed-off-by: Fernando Yang <hagisf@usp.br>
> ---
> drivers/iio/adc/ad7266.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
> index 356c2fe07..5a2f1bb27 100644
> --- a/drivers/iio/adc/ad7266.c
> +++ b/drivers/iio/adc/ad7266.c
> @@ -63,12 +63,14 @@ static int ad7266_powerdown(struct ad7266_state *st)
> static int ad7266_preenable(struct iio_dev *indio_dev)
> {
> struct ad7266_state *st = iio_priv(indio_dev);
> +
> return ad7266_wakeup(st);
> }
>
> static int ad7266_postdisable(struct iio_dev *indio_dev)
> {
> struct ad7266_state *st = iio_priv(indio_dev);
> +
> return ad7266_powerdown(st);
> }
>
> @@ -153,7 +155,7 @@ static int ad7266_read_raw(struct iio_dev *indio_dev,
> case IIO_CHAN_INFO_RAW:
> iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
> ret = ad7266_read_single(st, val, chan->address);
This is not needed as comment on patch 2.
> -
> +
> if (ret < 0)
> return ret;
> *val = (*val >> 2) & 0xfff;
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-06-08 5:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:54 [PATCH] iio: adc: adc7266: Use iio_device_claim_direct_scoped() Fernando Yang
2024-05-11 4:16 ` Marcelo Schmitt
2024-05-11 13:30 ` Jonathan Cameron
2024-06-03 18:07 ` [PATCH v2 1/3] iio: adc: ad7266: Fix variable checking bug Fernando Yang
2024-06-03 18:07 ` [PATCH v2 2/3] iio: adc: ad7266: Use iio_device_claim_direct_scoped() Fernando Yang
2024-06-08 5:21 ` Marcelo Schmitt
2024-06-03 18:07 ` [PATCH v2 3/3] iio: adc: ad7266: Fix codestyle error Fernando Yang
2024-06-08 5:29 ` Marcelo Schmitt [this message]
2024-06-08 5:06 ` [PATCH v2 1/3] iio: adc: ad7266: Fix variable checking bug Marcelo Schmitt
2024-06-08 14:11 ` Jonathan Cameron
2024-06-08 14:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmPsJH8k9ta100Ss@debian-BULLSEYE-live-builder-AMD64 \
--to=marcelo.schmitt1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=hagisf@usp.br \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.