From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4750F190043 for ; Mon, 17 Jun 2024 07:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718610955; cv=none; b=Zi2ujpEJ1NzLrs4Xvb3PFjAvA6BJtcKKI+XV3WoQ4UnCGzPcKev6dD9lHbjaXJnQjHfVj4KR2+qQK8ebFjI6ddcmpWfmJbSq/dKn+PAXdF9YCBI6BM27mhYzkmP8p92KAUwj2GHEmuhqvsct6mrTnpM0vTcRyuJ4JpxJ+A4Yu2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718610955; c=relaxed/simple; bh=JhFXSTpTbZnynjs4GWaWiZ25aqQJvGOYbY3MGHI2j0s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ccskw7stQ/SPzznDsXWt4KST8pf2wVO6uWs9edt2HFlReVAjPysjYKZVKF3JAtZHReyWTTp8hAd1CqgNjwT/zgN6YLKge9frMi2qzcrSVMVwWIrs61iOmcf4mgYt6f9YMjineZrnObQUWuNpxHWtCZUrD9VUrsFVG84dVwiNV3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=PRV+DM6j; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="PRV+DM6j" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-44051a92f37so33865881cf.1 for ; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1718610952; x=1719215752; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=PRV+DM6jEikbSJU+DC5oCjO9958pbLBhKoPEJFulkR6ypvkc5V6majzBGPX6ggfkHc JiqGZGqqKzIJrQBdH4mNGx2m9AOdeXg5HpVebQwqGi7bQt2+J4qCU0N99ekRoZdJzQu+ 7nJ/4+iQ7Gvdt/6F6LxjcFTJZ65VNeGv/HMbQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718610952; x=1719215752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=U/kbutdmZv3wxzxpHCgrh4Bq4FCAHpLH/gDgdmZO0bZFJnrDDvfHu/GcSRbTi4lS7i G+CXP3dpgkQBA1h3agEFjS4pWmkTRtwoDTAstHOSnSbZXILdRbxtVMAj0gVObb2Rz1Et j9Fgvu4qd/7oYvesxiZ9P3kT2Zn9hIH6VaLoHR5SJ18/hjIZhiQof+CzGj8hF0D8EMl/ wfvPhokUB4+UMet6MM2WDmI9HiPyUyOmHPFKx3H+ty1sB0WZNdX9Vg7KuEQKZvPWEliN AE1lTJMAZb4WPknSpFpOGHRoH3qxvSUOlITuF8z3JHQ3ITN+DPo3uKBChp1VekMW7ocW rj2g== X-Forwarded-Encrypted: i=1; AJvYcCV4wXwYFwWHdn2DpEuryF+lNH6dqsqx8q22+7MfxsQ79Ws+zlL4xGNFC2zOUHvttAjjyuS5cZYSWrSuhCLbm6X3iKHw8tdsDgSBZg== X-Gm-Message-State: AOJu0YxeqQBW8ZGVLngJlxhWFYtPDo/JZGGI0Y46syrFi8qsMsK5nc+S dcb6wRXN2TUocxOvkUOjElXovtH6DwzotZn+y9w1f5PE6ejBVXmml54Ozh6jQVQ= X-Google-Smtp-Source: AGHT+IFxBb+fxu+zFP9/mPYH5nZSCdE6S/NGqQ55TdkfvSsNQ6okiuS1Itv2iysUUW0wZGmJIGDYbg== X-Received: by 2002:ac8:5e11:0:b0:440:10be:3ecf with SMTP id d75a77b69052e-4417ac402c0mr199666251cf.22.1718610952095; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Received: from localhost ([213.195.124.163]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef4eefaesm44094171cf.21.2024.06.17.00.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 00:55:51 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Cc: Jens Axboe , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617060532.127975-2-hch@lst.de> On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to freeze the queue for that. Instead handle the case > of the feature flags cleared inside of blkfront. This removes old > debug code to check for such a mismatch which was previously impossible > to hit, including the check for passthrough requests that blkfront > never used to start with. > > Signed-off-by: Christoph Hellwig Acked-by: Roger Pau Monné Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA0CFC27C6E for ; Mon, 17 Jun 2024 07:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FJOZQB4gT9kEcqBwy+RR8TgNHSTH637U1fBFZ77XBz0=; b=H14S7JxoiHf13A 3ujJWQ7OkaUgRuMzd/fNxoUJ5Nn7VmpaAb2tqtt5YU0YFOeUzwvHfcUaYJgEAncWzO4y5Jfzxbcnh V7xzKeJyCFxfwbSd+HLEl63MtK3UFmlvpp70D/CVJPEaQyrtsP6ioHNVJmHMhXrbB2FBeV/cs0XLd F/dqB7vZ9Bsx+wijYjaYAH9eMDEgutVR5g0CLbb/5mNQhBi8kV5qCFq2EchITtd+PJjSFMOwf9x+m NuT1AwjgKX/Psucdqc+9QXn1RsgUPatDwdEmF7VJ1yqIFKYu+mZRd+8p+9zhYps3KuF21SnaxmQqp ztGZ2cCh8LhzfvzwR6yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ7DZ-00000009kzn-3LqK; Mon, 17 Jun 2024 07:55:57 +0000 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ7DX-00000009kyb-0iTf for linux-mtd@lists.infradead.org; Mon, 17 Jun 2024 07:55:57 +0000 Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-4415e623653so37857761cf.1 for ; Mon, 17 Jun 2024 00:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1718610952; x=1719215752; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=kde2Gi0dzGwmVuH61qNvwqRS6KjJ9M3gjKx4o5AlmgKD43mlJj2kwo+sqfJNDfOIT4 BfG7Co85W89bNm96HwWHLkkJtbVxrWyP7VGWeZqvniqqaqC1atqP0+VptFJ7PZOUhUp1 i5oEBtsbO62FDSKfncOB57UsDm2xNxURwXKyA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718610952; x=1719215752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=pe1pyzzclklTyYHENGE+6VflWSxcoN+deMYvFniVEX9KOJkMAiTqkZlxO5rc+nVxER EqjXdIpbqHdPIeeUwmqtzzIuRa6R7joA2C2mhe/rMlyv0o7VWK5Oe3Q4BIkfz8WX1A+b Okyb9zZBfk9QOshEdXCo9Y4Unl47CLIRq9yrV871l3C7aft6NSlAc1jzP5XJ18nWoDzf /7Nz8R7oM5GtWGfmOdaYwe3U4HlpIlVigbj79I3Ut2j9lHc9sFTCOxsjzikc+ZfQCFYy LIJcmptTiMuljdDnOjWiKPMUn/yroq+vskDQ5/oKvbvBDj8zHwDJQ8+DASXwCAxdqKm+ ufHw== X-Forwarded-Encrypted: i=1; AJvYcCVDJEEkfQlr62j2UVKUfKaoWCrrVsVntyaZTz6DW3XeoO3G5KoMcldQTpYtjztGKR6vg60+DZgIXrlgTwl4RDPwE32C3usgxSekA5m1/A== X-Gm-Message-State: AOJu0YwvbuMuxuqTIxNaAA/JYXV+IWVNWnzLmZyOdoioRBnl/n+U8zQw QUFgk2Gtn55TLKF31JLoloFwOJ5wFe9i8ZkLzyEEwFnqYzmYgleuQcQmZfu2Y5I= X-Google-Smtp-Source: AGHT+IFxBb+fxu+zFP9/mPYH5nZSCdE6S/NGqQ55TdkfvSsNQ6okiuS1Itv2iysUUW0wZGmJIGDYbg== X-Received: by 2002:ac8:5e11:0:b0:440:10be:3ecf with SMTP id d75a77b69052e-4417ac402c0mr199666251cf.22.1718610952095; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Received: from localhost ([213.195.124.163]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef4eefaesm44094171cf.21.2024.06.17.00.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 00:55:51 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Cc: Jens Axboe , Geert Uytterhoeven , Richard Weinberger , Philipp Reisner , Lars Ellenberg , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Josef Bacik , Ming Lei , "Michael S. Tsirkin" , Jason Wang , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Vineeth Vijayan , "Martin K. Petersen" , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240617060532.127975-2-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_005555_237474_9CA9A3CD X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMTcsIDIwMjQgYXQgMDg6MDQ6MjhBTSArMDIwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gYmxrZnJvbnQgYWx3YXlzIGhhZCBhIHJvYnVzdCBuZWdvdGlhdGlvbiBwcm90 b2NvbCBmb3IgZGV0ZWN0aW5nIGEgd3JpdGUKPiBjYWNoZS4gIFN0b3Agc2ltcGx5IGRpc2FibGlu ZyBjYWNoZSBmbHVzaGVzIGluIHRoZSBibG9jayBsYXllciBhcyB0aGUKPiBmbGFncyBoYW5kbGlu ZyBpcyBtb3ZpbmcgdG8gdGhlIGF0b21pYyBxdWV1ZSBsaW1pdHMgQVBJIHRoYXQgbmVlZHMKPiB1 c2VyIGNvbnRleHQgdG8gZnJlZXplIHRoZSBxdWV1ZSBmb3IgdGhhdC4gIEluc3RlYWQgaGFuZGxl IHRoZSBjYXNlCj4gb2YgdGhlIGZlYXR1cmUgZmxhZ3MgY2xlYXJlZCBpbnNpZGUgb2YgYmxrZnJv bnQuICBUaGlzIHJlbW92ZXMgb2xkCj4gZGVidWcgY29kZSB0byBjaGVjayBmb3Igc3VjaCBhIG1p c21hdGNoIHdoaWNoIHdhcyBwcmV2aW91c2x5IGltcG9zc2libGUKPiB0byBoaXQsIGluY2x1ZGlu ZyB0aGUgY2hlY2sgZm9yIHBhc3N0aHJvdWdoIHJlcXVlc3RzIHRoYXQgYmxrZnJvbnQKPiBuZXZl ciB1c2VkIHRvIHN0YXJ0IHdpdGguCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3 aWcgPGhjaEBsc3QuZGU+CgpBY2tlZC1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNp dHJpeC5jb20+CgpUaGFua3MsIFJvZ2VyLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlz dApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4AFDC41513 for ; Mon, 17 Jun 2024 07:56:48 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=citrix.com header.i=@citrix.com header.a=rsa-sha256 header.s=google header.b=wbgOeXB7; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W2hzf3cfBz3fnd for ; Mon, 17 Jun 2024 17:56:46 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=citrix.com header.i=@citrix.com header.a=rsa-sha256 header.s=google header.b=wbgOeXB7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=cloud.com (client-ip=2607:f8b0:4864:20::831; helo=mail-qt1-x831.google.com; envelope-from=roger.pau@cloud.com; receiver=lists.ozlabs.org) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W2hyp14y4z3dWk for ; Mon, 17 Jun 2024 17:55:59 +1000 (AEST) Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-4415e623653so37857841cf.1 for ; Mon, 17 Jun 2024 00:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1718610952; x=1719215752; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=wbgOeXB7u2pdv6hpjV4Av6+JWmvxEawOUWKeWyJd5M1JrKDT5m9Z8Y/2LAd+ZmpV6b tAqbUWP0i/NbvxNZ/APOqm8rijuAKEeMAUdWrhhWeRe9XphY/f1fLy9xzNjZ5aI5YbeS /EK9WIHcUqN7ntGn1UVLuxgDxf9oTpzOc9Lmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718610952; x=1719215752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I7HjTVD0FYGpGJyzdWr9lYyHGbtAeqv6wNa85E5Tlk=; b=Za7LFbgietL3tcwt2Y4aCQU7K8dMWB/qdVIY2/9XVJDwQKH0MUyDqxPBXeScit0q4/ +4rNZ0boVIoMQ3ecsVYVYaFFNAFKRdANvZilY+Pdwk+nMf1ukxNHBRNoXED6jlSi4hTK smSFSLN5j9PZnjSVcQBEH2IfImKkvqsC2bQozXdJkWuCZ2/uTpfttDF69Svnb7dcnhek z/otILEEsA7botXPzMRwrQLjTl3zn1sV3VlDjAD7ocXHatBuQ7KsD9d8pHUs1y37bRVh jlPk2mWcoSkRbxxBuEx6y/biTTZ9CoweblrHhIfs0CIK9nYN3Os5ilMQQo+VTyosrKWL EF1w== X-Forwarded-Encrypted: i=1; AJvYcCUXqf2gVZRaLeIF0bBWO9rxUb3EZpTDwKcGKs/FChXQkYpVwYk8WtqAH+84lyYW87d7msvbm8HOMU/vjJE9oPZBbcXUeOTFhAbYnRmrCg== X-Gm-Message-State: AOJu0YwrNVnZekLWalJ/1tWjibJXXpJPL2JFeQmwzRVMW2uuH6Ej4GPY V+hodNYeVm0FfRNOxCsNizcHfdh+Wl3zHnxfMUB4ss/JtjlsuzF0Zeqbt961O+A= X-Google-Smtp-Source: AGHT+IFxBb+fxu+zFP9/mPYH5nZSCdE6S/NGqQ55TdkfvSsNQ6okiuS1Itv2iysUUW0wZGmJIGDYbg== X-Received: by 2002:ac8:5e11:0:b0:440:10be:3ecf with SMTP id d75a77b69052e-4417ac402c0mr199666251cf.22.1718610952095; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Received: from localhost ([213.195.124.163]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef4eefaesm44094171cf.21.2024.06.17.00.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 00:55:51 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617060532.127975-2-hch@lst.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , linux-bcache@vger.kernel.org, Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , Ming Lei , linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, nbd@other.debian.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to freeze the queue for that. Instead handle the case > of the feature flags cleared inside of blkfront. This removes old > debug code to check for such a mismatch which was previously impossible > to hit, including the check for passthrough requests that blkfront > never used to start with. > > Signed-off-by: Christoph Hellwig Acked-by: Roger Pau Monné Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 4F4FC420607 for ; Mon, 17 Jun 2024 09:55:52 +0200 (CEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4405743ac19so35246081cf.0 for ; Mon, 17 Jun 2024 00:55:52 -0700 (PDT) Date: Mon, 17 Jun 2024 09:55:48 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Christoph Hellwig Subject: Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail Message-ID: References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617060532.127975-2-hch@lst.de> Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , linux-bcache@vger.kernel.org, Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , Ming Lei , linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, nbd@other.debian.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jun 17, 2024 at 08:04:28AM +0200, Christoph Hellwig wrote: > blkfront always had a robust negotiation protocol for detecting a write > cache. Stop simply disabling cache flushes in the block layer as the > flags handling is moving to the atomic queue limits API that needs > user context to freeze the queue for that. Instead handle the case > of the feature flags cleared inside of blkfront. This removes old > debug code to check for such a mismatch which was previously impossible > to hit, including the check for passthrough requests that blkfront > never used to start with. > > Signed-off-by: Christoph Hellwig Acked-by: Roger Pau Monné Thanks, Roger.