From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Benjamin Marzinski <bmarzins@redhat.com>
Subject: Re: [PATCH v6 2/4] dm: Call dm_revalidate_zones() after setting the queue limits
Date: Mon, 10 Jun 2024 09:16:21 +0200 [thread overview]
Message-ID: <ZmaoRbmid0WSrmof@ryzen.lan> (raw)
In-Reply-To: <20240606082147.96422-3-dlemoal@kernel.org>
On Thu, Jun 06, 2024 at 05:21:45PM +0900, Damien Le Moal wrote:
> dm_revalidate_zones() is called from dm_set_zone_restrictions() when the
> mapped device queue limits are not yet set. However,
> dm_revalidate_zones() calls blk_revalidate_disk_zones() and this
> function consults and modifies the mapped device queue limits. Thus,
> currently, blk_revalidate_disk_zones() operates on limits that are not
> yet initialized.
>
> Fix this by moving the call to dm_revalidate_zones() out of
> dm_set_zone_restrictions() and into dm_table_set_restrictions() after
> executing queue_limits_set().
>
> To further cleanup dm_set_zones_restrictions(), the message about the
> type of zone append (native or emulated) is also moved inside
> dm_revalidate_zones().
>
> Fixes: 1c0e720228ad ("dm: use queue_limits_set")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2024-06-10 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:21 [PATCH v6 0/4] Fix DM zone resource limits stacking Damien Le Moal
2024-06-06 8:21 ` [PATCH v6 1/4] block: Improve checks on zone resource limits Damien Le Moal
2024-06-10 7:15 ` Niklas Cassel
2024-06-06 8:21 ` [PATCH v6 2/4] dm: Call dm_revalidate_zones() after setting the queue limits Damien Le Moal
2024-06-06 19:40 ` Benjamin Marzinski
2024-06-10 7:16 ` Niklas Cassel [this message]
2024-06-06 8:21 ` [PATCH v6 3/4] dm: Improve zone resource limits handling Damien Le Moal
2024-06-06 19:41 ` Benjamin Marzinski
2024-06-10 7:18 ` Niklas Cassel
2024-06-06 8:21 ` [PATCH v6 4/4] dm: Remove unused macro DM_ZONE_INVALID_WP_OFST Damien Le Moal
2024-06-10 7:19 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmaoRbmid0WSrmof@ryzen.lan \
--to=cassel@kernel.org \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dlemoal@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.