Re: [PATCH 1/1] ioctl_epoll.2: New page describing ioctl(2) operations for epoll fds

[Joe Damato <jdamato@fastly.com>]

On Sun, Jun 09, 2024 at 07:04:40PM +0200, Alejandro Colomar wrote:
> Hi Joe,
> 
> On Fri, Jun 07, 2024 at 02:53:19PM GMT, Joe Damato wrote:
> > On Thu, Jun 06, 2024 at 11:46:47PM +0200, Alejandro Colomar wrote:
> > > $ make lint build check -j24
> > > GROTTY		.tmp/man/man2/epoll_create.2.cat
> > > GROTTY		.tmp/man/man2/epoll_ctl.2.cat
> > > TROFF		.tmp/man/man2/ioctl_epoll.2.cat.set
> > > an.tmac:.tmp/man/man2/ioctl_epoll.2:61: style: blank line in input
> > > make: *** [/home/alx/src/linux/man-pages/man-pages/contrib/share/mk/build/catman/troff.mk:63: .tmp/man/man2/ioctl_epoll.2.cat.set] Error 1
> > > make: *** Deleting file '.tmp/man/man2/ioctl_epoll.2.cat.set'
> > 
> > Hmm..
> > 
> > When I run make I get an error:
> > 
> > $ make
> > TROFF		.tmp/man/man2/s390_sthyi.2.cat.set
> > troff: .tmp/man/man2/s390_sthyi.2:124: warning [p 2, 2.8i]: cannot adjust line
> 
> Hmm, I can't reproduce it.  Can you run with `make --debug=print` (needs
> a recent make(1))?

I don't think I have a recent enough make:

$ make --debug=print
make: *** unknown debug level specification 'print'.  Stop.
$ make --version
GNU Make 4.3


> > I tried to run the lint build check target and got an error about
> > checkpatch:
> > 
> > $ make lint build check -j8
> > CHECKPATCH	.tmp/man/man2/fork.2.d/fork.c.lint-c.checkpatch.touch
> > bash: line 1: checkpatch: command not found
> > 
> > I have mandoc, groff, and clang-tidy installed, but maybe I'm
> > missing other dependency?
> 
> That's a fork of the checkpatch.pl from the kernel.  I'm working on a
> repository to make it public.  Don't worry about it.
> 
> You can `make -t lint-c-checkpatch` to ignore all checkpatch lints.

$ make -t lint-c-checkpatch
$ echo $?
0

Does that mean I'm good to go and ready to submit v2 ? ;)

> 
> Have a lovely day!
> Alex
> 
> -- 
> <https://www.alejandro-colomar.es/>