From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
<intel-gvt-dev@lists.freedesktop.org>,
<ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 6/6] drm/i915: remove unused pipe/plane B register macros
Date: Mon, 10 Jun 2024 15:32:05 -0400 [thread overview]
Message-ID: <ZmdUtZei8kb0X0Un@intel.com> (raw)
In-Reply-To: <16d278bea466a69cdce94fd83d98dd15ce1a8c89.1717773890.git.jani.nikula@intel.com>
On Fri, Jun 07, 2024 at 06:25:40PM +0300, Jani Nikula wrote:
> None of these are used. The parametrized register macros all depend on
> the pipe/plane A offset macros alone. Remove the unused ones.
>
> v2: Rebase
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 2a14dd9ef4a0..a33f3a61a9a4 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2214,27 +2214,6 @@
> #define SWF3(dev_priv, i) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x72414 + (i) * 4)
> #define SWF_ILK(i) _MMIO(0x4F000 + (i) * 4)
>
> -/* Pipe B */
> -#define _PIPEBDSL (DISPLAY_MMIO_BASE(dev_priv) + 0x71000)
> -#define _TRANSBCONF (DISPLAY_MMIO_BASE(dev_priv) + 0x71008)
> -#define _PIPEBSTAT (DISPLAY_MMIO_BASE(dev_priv) + 0x71024)
> -#define _PIPEBFRAMEHIGH 0x71040
> -#define _PIPEBFRAMEPIXEL 0x71044
> -#define _PIPEB_FRMCOUNT_G4X (DISPLAY_MMIO_BASE(dev_priv) + 0x71040)
> -#define _PIPEB_FLIPCOUNT_G4X (DISPLAY_MMIO_BASE(dev_priv) + 0x71044)
> -
> -
> -/* Display B control */
> -#define _DSPBCNTR (DISPLAY_MMIO_BASE(dev_priv) + 0x71180)
> -#define _DSPBADDR (DISPLAY_MMIO_BASE(dev_priv) + 0x71184)
> -#define _DSPBSTRIDE (DISPLAY_MMIO_BASE(dev_priv) + 0x71188)
> -#define _DSPBPOS (DISPLAY_MMIO_BASE(dev_priv) + 0x7118C)
> -#define _DSPBSIZE (DISPLAY_MMIO_BASE(dev_priv) + 0x71190)
> -#define _DSPBSURF (DISPLAY_MMIO_BASE(dev_priv) + 0x7119C)
> -#define _DSPBTILEOFF (DISPLAY_MMIO_BASE(dev_priv) + 0x711A4)
> -#define _DSPBOFFSET (DISPLAY_MMIO_BASE(dev_priv) + 0x711A4)
> -#define _DSPBSURFLIVE (DISPLAY_MMIO_BASE(dev_priv) + 0x711AC)
> -
> /* ICL DSI 0 and 1 */
> #define _PIPEDSI0CONF 0x7b008
> #define _PIPEDSI1CONF 0x7b808
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-06-10 19:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 15:25 [PATCH v2 0/6] drm/i915: gvt register macro cleanups, unused macro removals Jani Nikula
2024-06-07 15:25 ` [PATCH v2 1/6] drm/i915/gvt: remove the unused end parameter from calc_index() Jani Nikula
2024-06-07 15:52 ` Zhi Wang
2024-06-07 15:25 ` [PATCH v2 2/6] drm/i915/gvt: use proper i915_reg_t for calc_index() parameters Jani Nikula
2024-06-10 10:56 ` Zhi Wang
2024-06-07 15:25 ` [PATCH v2 3/6] drm/i915/gvt: rename range variable to stride Jani Nikula
2024-06-10 10:57 ` Zhi Wang
2024-06-07 15:25 ` [PATCH v2 4/6] drm/i915/gvt: do not use implict dev_priv in DSPSURF_TO_PIPE() Jani Nikula
2024-06-10 10:58 ` Zhi Wang
2024-06-07 15:25 ` [PATCH v2 5/6] drm/i915: relocate some DSPCNTR reg bit definitions Jani Nikula
2024-06-10 19:31 ` Rodrigo Vivi
2024-06-07 15:25 ` [PATCH v2 6/6] drm/i915: remove unused pipe/plane B register macros Jani Nikula
2024-06-10 19:32 ` Rodrigo Vivi [this message]
2024-06-07 17:36 ` ✗ Fi.CI.SPARSE: warning for drm/i915: gvt register macro cleanups, unused macro removals (rev2) Patchwork
2024-06-07 17:47 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-13 11:51 ` ✓ Fi.CI.BAT: success for drm/i915: gvt register macro cleanups, unused macro removals (rev3) Patchwork
2024-06-14 3:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-14 8:20 ` [PATCH v2 0/6] drm/i915: gvt register macro cleanups, unused macro removals Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmdUtZei8kb0X0Un@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.