From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCFB3D556 for ; Tue, 11 Jun 2024 16:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121792; cv=none; b=WrrDtakrn+qMw65/LoYVK6eW2gIUkejbxn9Ft/yh/FAGhGD6Bp1vxQb1JdL6rfyppKlp0rlikYdUhD3mCVb1MeqYVj80Eisku4Z/RGJE+6ry+kMHSWWKjqnB5OQ0JavIidYIbSr4d7oc5ybUF4CBKFftOi+6yKfGivc+jorTh0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121792; c=relaxed/simple; bh=85XwKIEyD8KckQ6PkEQV+MMGpUPEf6eImQT/QBrvAe0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mmRg98VJSfXFSTYmYHziGIC5AhRBwsx4uLkaG1qsTtRQqxPpAoSQBkbG6UV+lDqmCg5y1+exZQoiRRuD7dZTPl5/PEAz2o9OGSDzXPqFBfeXwzKBunmENudXVWIhAy/t9klWmGlHswtW722KW8lWJ4r0PZhSMVi3+gNgqkHshoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ay7oes3+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ay7oes3+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718121790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JSREr6R5C0Ap27lAslygWCiIveFJotp7zWPFYC5XIhc=; b=Ay7oes3+UeBCZx/M/VdduEujWK0gEUJxM7cmnkpmMZXiGMrnA4sEtXDO9/PiI1HXmZgjGf CYoYjUxtNpwJAraHbG9SplCPu1aPDQYFrOvttWXjEDQRY6l36fhsQl/NlZb8N09icsI9I1 ot44ta2QjKODjIRHvHPn3COSa0YKs54= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-zdhD56xjP8yx4QZeJySXeg-1; Tue, 11 Jun 2024 12:03:06 -0400 X-MC-Unique: zdhD56xjP8yx4QZeJySXeg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7954f774295so421214685a.2 for ; Tue, 11 Jun 2024 09:03:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718121785; x=1718726585; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JSREr6R5C0Ap27lAslygWCiIveFJotp7zWPFYC5XIhc=; b=rM/qOM4NVXiAa7TNcbTNTIPJnq4bQAcZ0+SIXUEWHLJJZhX+rOJuL014lDdD3YnG9C 0wjIr7PW925jVZRVNChGjCrQjQRWxFo2WiCtcn63Y/MVCJ6WvqwFUAW3oFNEnoR+U4MN We3jpPrX8tMVeOKfjflippT3XP6yXB5zfOozoNQfER3Hb65P+MCw5trielfyCogwVQkQ xYKleCYBnS4QKLsNEjvCAbKqfQ/t1FUxnZOqgeFrm0NI1dt+3ShkUUjeelVfiot3FkIO BVY0IKW/xiSqKnfhkKuFptdLcoWTJpq4HOZSS1Nb0iPgw4xc3NKv3VxbdXgrJ/sghNXt BbRw== X-Gm-Message-State: AOJu0Yw52Z0TfFo7nRmWrgX0XiWYQ9smuCBOpk0J8VN7xtBBj8sYxrWP Yv8P4zpDuTO+Khr3nrwrWFYsdQpFOAHoGZIMkGpR/oWEVd+BU4nfQveIdIotINhq0j7JR0T7BAZ QvRgPpEehVE5beDkjr1ggZg7f6WeyyYpmcbpASONyiEOZmv2C71m2KSxD+ATYSQ== X-Received: by 2002:a05:620a:4409:b0:795:5033:a79c with SMTP id af79cd13be357-7955033a906mr1152936885a.67.1718121784857; Tue, 11 Jun 2024 09:03:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGX9IQDx0X5A/HraO373mXuCGpMD9QViO3pahJV6Ze3wwS4HkXgImRkv8Ny+AWAOUGLBc7DQ== X-Received: by 2002:a05:620a:4409:b0:795:5033:a79c with SMTP id af79cd13be357-7955033a906mr1152932985a.67.1718121784391; Tue, 11 Jun 2024 09:03:04 -0700 (PDT) Received: from optiplex-fbsd (c-76-152-42-226.hsd1.nh.comcast.net. [76.152.42.226]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79558163eeasm302010785a.124.2024.06.11.09.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 09:03:04 -0700 (PDT) Date: Tue, 11 Jun 2024 12:03:01 -0400 From: Rafael Aquini To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier Subject: Re: [PATCH] kbuild: rpm-pkg: fix rpmbuild warnings for kernel.spec Message-ID: References: <20240610163856.693110-1-aquini@redhat.com> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jun 12, 2024 at 12:00:18AM +0900, Masahiro Yamada wrote: > On Tue, Jun 11, 2024 at 1:39 AM Rafael Aquini wrote: > > > > Newer revisions of rpmbuild are throwing warnings about the current > > kernel.spec template having an unversioned kernel-headers in the > > 'Obsoletes:' field and not being able to source the epoch's date from > > the spec's missing '%changelog' section: > > > > $ make srcrpm-pkg > > UPD include/config/kernel.release > > GEN rpmbuild/SPECS/kernel.spec > > UPD .tmp_HEAD > > ARCHIVE linux.tar.gz > > rpmbuild -bs rpmbuild/SPECS/kernel.spec --define='_topdir /mnt/nfs/work/kernel/linux/rpmbuild' > > warning: line 34: It's not recommended to have unversioned Obsoletes: Obsoletes: kernel-headers > > warning: source_date_epoch_from_changelog set but %changelog is missing > > Wrote: /mnt/nfs/work/kernel/linux/rpmbuild/SRPMS/kernel-6.10.0_rc3-1.src.rpm > > > > RPM build warnings: > > line 34: It's not recommended to have unversioned Obsoletes: Obsoletes: kernel-headers > > source_date_epoch_from_changelog set but %changelog is missing > > > > This patch addresses both RPM build warnings. > > > > Signed-off-by: Rafael Aquini > > --- > > scripts/package/kernel.spec | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/package/kernel.spec b/scripts/package/kernel.spec > > index e095eb1e290e..4d58b29c03ad 100644 > > --- a/scripts/package/kernel.spec > > +++ b/scripts/package/kernel.spec > > @@ -1,3 +1,5 @@ > > +%global source_date_epoch_from_changelog 0 > > > > > Another possibility might be to add %changelog section. > > In Debian packaging, debian/changelog is a requirement. > > scripts/package/mkdebian generates a very small > debian/changelog with a single log entry. > I'll take a stab at it, then. Thanks for the pointer! Cheers, -- Rafael