Re: [kvm-x86:generic 7/9] include/linux/kvm_host.h:2106:5: warning: no previous prototype for 'kvm_init_irq_routing'

[Sean Christopherson <seanjc@google.com>]

On Tue, Jun 11, 2024, kernel test robot wrote:
> tree:   https://github.com/kvm-x86/linux generic
> head:   96545c0ccf1cdcbeeaca77399af27da12da6c833
> commit: 2207798ccd0adc8995a71f93fd77c8ece3eb330a [7/9] KVM: Setup empty IRQ routing when creating a VM
> config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20240611/202406111054.tfC7sg5g-lkp@intel.com/config)
> compiler: powerpc-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240611/202406111054.tfC7sg5g-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406111054.tfC7sg5g-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from arch/powerpc/include/asm/kvm_ppc.h:19,
>                     from arch/powerpc/include/asm/dbell.h:17,
>                     from arch/powerpc/kernel/asm-offsets.c:36:
> >> include/linux/kvm_host.h:2106:5: warning: no previous prototype for 'kvm_init_irq_routing' [-Wmissing-prototypes]
>     2106 | int kvm_init_irq_routing(struct kvm *kvm) {}
>          |     ^~~~~~~~~~~~~~~~~~~~
>    include/linux/kvm_host.h: In function 'kvm_init_irq_routing':
> >> include/linux/kvm_host.h:2106:44: warning: control reaches end of non-void function [-Wreturn-type]
>     2106 | int kvm_init_irq_routing(struct kvm *kvm) {}
>          |                                            ^
> --
>    In file included from arch/powerpc/include/asm/kvm_ppc.h:19,
>                     from arch/powerpc/include/asm/dbell.h:17,
>                     from arch/powerpc/kernel/asm-offsets.c:36:
> >> include/linux/kvm_host.h:2106:5: warning: no previous prototype for 'kvm_init_irq_routing' [-Wmissing-prototypes]
>     2106 | int kvm_init_irq_routing(struct kvm *kvm) {}
>          |     ^~~~~~~~~~~~~~~~~~~~
>    include/linux/kvm_host.h: In function 'kvm_init_irq_routing':
> >> include/linux/kvm_host.h:2106:44: warning: control reaches end of non-void function [-Wreturn-type]
>     2106 | int kvm_init_irq_routing(struct kvm *kvm) {}
>          |                                            ^
> 
> 
> vim +/kvm_init_irq_routing +2106 include/linux/kvm_host.h
> 
>   2104	
>   2105	static inline void kvm_free_irq_routing(struct kvm *kvm) {}
> > 2106	int kvm_init_irq_routing(struct kvm *kvm) {}
>   2107	

Our friendly test bot beat me to build testing.  Will squash this:

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 82726050fc76..eaa70e9b1218 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -2103,7 +2103,11 @@ void kvm_free_irq_routing(struct kvm *kvm);
 #else
 
 static inline void kvm_free_irq_routing(struct kvm *kvm) {}
-int kvm_init_irq_routing(struct kvm *kvm) {}
+
+static inline int kvm_init_irq_routing(struct kvm *kvm)
+{
+       return 0;
+}
 
 #endif