All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 4/7] x86/irq: restrict CPU movement in set_desc_affinity()
Date: Wed, 12 Jun 2024 10:31:06 +0200	[thread overview]
Message-ID: <ZmlcyqkHh562lL2j@macbook> (raw)
In-Reply-To: <b2e8eed9-1df8-442b-ae7e-401c406eaef8@suse.com>

On Tue, Jun 11, 2024 at 12:20:33PM +0200, Jan Beulich wrote:
> On 10.06.2024 16:20, Roger Pau Monne wrote:
> > If external interrupts are using logical mode it's possible to have an overlap
> > between the current ->arch.cpu_mask and the provided mask (or TARGET_CPUS).  If
> > that's the case avoid assigning a new vector and just move the interrupt to a
> > member of ->arch.cpu_mask that overlaps with the provided mask and is online.
> 
> What I'm kind of missing here is an explanation of why what _assign_irq_vector()
> does to avoid unnecessary migration (very first conditional there) isn't
> sufficient.

Somehow I looked at that and think it wasn't enough, but now I cannot
figure out why, so it might be just fine, and this patch is not
needed.  Let me test again and get back to you, for the time being
ignore this patch.

Thanks, Roger.


  reply	other threads:[~2024-06-12  8:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 14:20 [PATCH v2 0/7] x86/irq: fixes for CPU hot{,un}plug Roger Pau Monne
2024-06-10 14:20 ` [PATCH v2 1/7] x86/smp: do not use shorthand IPI destinations in CPU hot{,un}plug contexts Roger Pau Monne
2024-06-11  7:42   ` Jan Beulich
2024-06-12  8:09     ` Roger Pau Monné
2024-06-12  8:56       ` Jan Beulich
2024-06-12 10:07         ` Oleksii K.
2024-06-10 14:20 ` [PATCH v2 2/7] x86/irq: describe how the interrupt CPU movement works Roger Pau Monne
2024-06-11  7:44   ` Jan Beulich
2024-06-12 10:08     ` Oleksii K.
2024-06-10 14:20 ` [PATCH v2 3/7] x86/irq: limit interrupt movement done by fixup_irqs() Roger Pau Monne
2024-06-11  9:59   ` Jan Beulich
2024-06-12  8:10     ` Roger Pau Monné
2024-06-12 10:13     ` Oleksii K.
2024-06-10 14:20 ` [PATCH v2 4/7] x86/irq: restrict CPU movement in set_desc_affinity() Roger Pau Monne
2024-06-11 10:20   ` Jan Beulich
2024-06-12  8:31     ` Roger Pau Monné [this message]
2024-06-10 14:20 ` [PATCH v2 5/7] x86/irq: deal with old_cpu_mask for interrupts in movement in fixup_irqs() Roger Pau Monne
2024-06-11 12:45   ` Jan Beulich
2024-06-12  8:47     ` Roger Pau Monné
2024-06-12  9:04       ` Jan Beulich
2024-06-12 10:41         ` Roger Pau Monné
2024-06-11 13:47   ` Jan Beulich
2024-06-12  8:36     ` Roger Pau Monné
2024-06-10 14:20 ` [PATCH v2 6/7] x86/irq: handle moving interrupts in _assign_irq_vector() Roger Pau Monne
2024-06-11 13:18   ` Jan Beulich
2024-06-12 10:39     ` Roger Pau Monné
2024-06-12 13:42       ` Jan Beulich
2024-06-12 15:36         ` Roger Pau Monné
2024-06-13  8:38           ` Jan Beulich
2024-06-13 11:31             ` Roger Pau Monné
2024-06-13 11:36               ` Jan Beulich
2024-06-13 12:55                 ` Roger Pau Monné
2024-06-13 13:07                   ` Jan Beulich
2024-06-10 14:20 ` [PATCH v2 7/7] x86/irq: forward pending interrupts to new destination in fixup_irqs() Roger Pau Monne
2024-06-11 13:50   ` Jan Beulich
2024-06-12 11:23     ` Roger Pau Monné
2024-06-12 13:47       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmlcyqkHh562lL2j@macbook \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.