From: Uladzislau Rezki <urezki@gmail.com>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>, Baoquan He <bhe@redhat.com>
Cc: Uladzislau Rezki <urezki@gmail.com>,
"zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Lorenzo Stoakes <lstoakes@gmail.com>, Baoquan He <bhe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
hailong liu <hailong.liu@oppo.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, steve.kang@unisoc.com
Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block
Date: Wed, 12 Jun 2024 13:27:26 +0200 [thread overview]
Message-ID: <ZmmGHhUDk5PqSHPB@pc636> (raw)
In-Reply-To: <CAGWkznGnaV8Tz0XrgaVWEVG0ug7dp3w23ygKKmq8SPu_AMBhoA@mail.gmail.com>
On Wed, Jun 12, 2024 at 10:00:14AM +0800, Zhaoyang Huang wrote:
> On Wed, Jun 12, 2024 at 2:16 AM Uladzislau Rezki <urezki@gmail.com> wrote:
> >
> > >
> > > Sorry to bother you again. Are there any other comments or new patch
> > > on this which block some test cases of ANDROID that only accept ACKed
> > > one on its tree.
> > >
> > I have just returned from vacation. Give me some time to review your
> > patch. Meanwhile, do you have a reproducer? So i would like to see how
> > i can trigger an issue that is in question.
> This bug arises from an system wide android test which has been
> reported by many vendors. Keep mount/unmount an erofs partition is
> supposed to be a simple reproducer. IMO, the logic defect is obvious
> enough to be found by code review.
>
Baoquan, any objection about this v4?
Your proposal about inserting a new vmap-block based on it belongs
to, i.e. not per-this-cpu, should fix an issue. The problem is that
such way does __not__ pre-load a current CPU what is not good.
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-06-12 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 2:31 [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block zhaoyang.huang
2024-06-07 3:37 ` kernel test robot
2024-06-07 8:30 ` Zhaoyang Huang
2024-06-11 1:08 ` Zhaoyang Huang
2024-06-11 18:16 ` Uladzislau Rezki
2024-06-12 2:00 ` Zhaoyang Huang
2024-06-12 11:27 ` Uladzislau Rezki [this message]
2024-06-13 8:41 ` Baoquan He
2024-06-13 9:11 ` hailong liu
2024-06-13 9:23 ` Zhaoyang Huang
2024-06-14 1:44 ` Baoquan He
2024-06-13 11:28 ` Uladzislau Rezki
2024-06-14 1:32 ` Baoquan He
2024-06-13 11:42 ` hailong liu
2024-06-13 17:33 ` Uladzislau Rezki
2024-06-13 20:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmmGHhUDk5PqSHPB@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hailong.liu@oppo.com \
--cc=hch@infradead.org \
--cc=huangzhaoyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steve.kang@unisoc.com \
--cc=tglx@linutronix.de \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.