From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: johan@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg'
Date: Thu, 13 Jun 2024 13:28:57 +0000 [thread overview]
Message-ID: <Zmr0GV57EGwxcYeM@gallifrey> (raw)
In-Reply-To: <20240529234722.130609-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'spcp8x5_usb_ctrl_arg' has been unused since the original
> commit 619a6f1d1423 ("USB: add usb-serial spcp8x5 driver").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping?
Dave
> ---
> drivers/usb/serial/spcp8x5.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
> index 09a972a838ee..6b294bf8bc43 100644
> --- a/drivers/usb/serial/spcp8x5.c
> +++ b/drivers/usb/serial/spcp8x5.c
> @@ -49,16 +49,6 @@ static const struct usb_device_id id_table[] = {
> };
> MODULE_DEVICE_TABLE(usb, id_table);
>
> -struct spcp8x5_usb_ctrl_arg {
> - u8 type;
> - u8 cmd;
> - u8 cmd_type;
> - u16 value;
> - u16 index;
> - u16 length;
> -};
> -
> -
> /* spcp8x5 spec register define */
> #define MCR_CONTROL_LINE_RTS 0x02
> #define MCR_CONTROL_LINE_DTR 0x01
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-06-13 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 23:47 [PATCH] USB: serial: spcp8x5: remove unused struct 'spcp8x5_usb_ctrl_arg' linux
2024-06-13 13:28 ` Dr. David Alan Gilbert [this message]
2024-06-13 13:39 ` Greg KH
2024-06-13 16:58 ` Dr. David Alan Gilbert
2024-07-05 11:01 ` Johan Hovold
2024-07-05 12:52 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmr0GV57EGwxcYeM@gallifrey \
--to=linux@treblig.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.