From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: harald.mommer@opensynergy.com, mvaralar@redhat.com, sgarzare@redhat.com
Subject: [PATCH v1] virtio-can: rephrase notification mechanism
Date: Thu, 13 Jun 2024 17:59:26 +0200 [thread overview]
Message-ID: <ZmsXXumHlQXnU2Wm@fedora> (raw)
Rephrase when the device may omit to notify the driver due to a status
change in a more straight-forward way.
Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
---
* This patch applies on top of virtio-1.4, which has not been released
yet.
v0 -> v1:
* Rephrase commit message
---
device-types/can/description.tex | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/device-types/can/description.tex b/device-types/can/description.tex
index 2511d9c..b13da9c 100644
--- a/device-types/can/description.tex
+++ b/device-types/can/description.tex
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
\end{lstlisting}
If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification when the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.
On transition to the STOPPED state the device cancels all CAN messages
already pending for transmission and marks them as used with
base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2
--
2.42.0
next reply other threads:[~2024-06-13 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 15:59 Matias Ezequiel Vara Larsen [this message]
2024-06-19 8:24 ` [PATCH v1] virtio-can: rephrase notification mechanism Stefano Garzarella
2024-06-21 13:45 ` Matias Ezequiel Vara Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmsXXumHlQXnU2Wm@fedora \
--to=mvaralar@redhat.com \
--cc=harald.mommer@opensynergy.com \
--cc=sgarzare@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.