From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ben Walsh <ben@jubnut.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Fix error code in cros_ec_lpc_mec_read_bytes()
Date: Fri, 14 Jun 2024 02:21:13 +0000 [thread overview]
Message-ID: <ZmupGcjkuU0bNtdl@google.com> (raw)
In-Reply-To: <87o784ac55.fsf@jubnut.com>
On Thu, Jun 13, 2024 at 08:14:14PM +0100, Ben Walsh wrote:
> Tzung-Bi Shih <tzungbi@kernel.org> writes:
> > On Thu, Jun 13, 2024 at 05:51:39PM +0100, Ben Walsh wrote:
> >> or 2. Put in a check for length == 0.
> >>
> >> or 3. Change the logic in `fwk_ec_lpc_mec_in_range`. Although I'm not
> >> sure what the correct answer is to "zero length is in range?"
> >>
> >> I prefer option 2. What do you think?
> >
> > How about drop the length check at [2]?
> >
> > [2]: https://elixir.bootlin.com/linux/v6.9/source/drivers/platform/chrome/cros_ec_lpc_mec.c#L44
> >
>
> This works, but we still end up calling cros_ec_lpc_io_bytes_mec() with
> zero length. Although this seems to work fine, we could put a length
> check at the top of cros_ec_lpc_read_bytes() to avoid it.
I guess you mean: cros_ec_lpc_io_bytes_mec(). Ack.
next prev parent reply other threads:[~2024-06-14 2:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 13:55 [PATCH] platform/chrome: cros_ec_lpc: Fix error code in cros_ec_lpc_mec_read_bytes() Dan Carpenter
2024-06-13 14:02 ` Guenter Roeck
2024-06-13 15:20 ` patchwork-bot+chrome-platform
2024-06-13 15:20 ` patchwork-bot+chrome-platform
2024-06-13 16:51 ` Ben Walsh
2024-06-13 17:40 ` Tzung-Bi Shih
2024-06-13 19:14 ` Ben Walsh
2024-06-14 2:21 ` Tzung-Bi Shih [this message]
2024-06-13 19:19 ` Ben Walsh
2024-06-13 17:57 ` Dan Carpenter
2024-06-13 18:20 ` Ben Walsh
2024-06-13 18:34 ` Dan Carpenter
2024-06-13 20:50 ` Ben Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmupGcjkuU0bNtdl@google.com \
--to=tzungbi@kernel.org \
--cc=ben@jubnut.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=groeck@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.