From: Christoph Hellwig <hch@infradead.org>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <kbusch@kernel.org>,
Andreas Hindborg <nmi@metaspace.dk>, Jens Axboe <axboe@kernel.dk>,
Andreas Hindborg <a.hindborg@samsung.com>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <dlemoal@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] null_blk: fix validation of block size
Date: Fri, 28 Jun 2024 22:07:50 -0700 [thread overview]
Message-ID: <Zn-Wpq2AzBo6rcgd@infradead.org> (raw)
In-Reply-To: <8f8f8f78-fcd4-4e71-8dd5-bae03a627a34@oracle.com>
On Fri, Jun 28, 2024 at 03:30:00PM +0100, John Garry wrote:
> On 04/06/2024 05:46, Christoph Hellwig wrote:
> > > It also looks like a good idea if this check was just done in
> > > blk_validate_limits() so that each driver doesn't have to do their own
> > > checks. That block function is kind of recent though.
> > Yes. We already discussed this in another thread a few days ago.
> Has anyone taken this work? I was going to unless someone else wants to. 4
> or 5 drivers directly reference blk_validate_block_size() now.
I haven't look at it yet, so from my point of view feel free to tackle
it.
next prev parent reply other threads:[~2024-06-29 5:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 19:26 [PATCH v2] null_blk: fix validation of block size Andreas Hindborg
2024-06-03 19:47 ` Keith Busch
2024-06-04 4:46 ` Christoph Hellwig
2024-06-28 14:30 ` John Garry
2024-06-29 5:07 ` Christoph Hellwig [this message]
2024-07-03 12:20 ` blk_validate_limits validation of block size (was Re: [PATCH v2] null_blk: fix validation of block size) John Garry
2024-07-03 13:19 ` Christoph Hellwig
2024-07-03 17:28 ` John Garry
2024-07-04 6:18 ` Christoph Hellwig
2024-06-04 1:27 ` [PATCH v2] null_blk: fix validation of block size Ming Lei
2024-06-04 14:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn-Wpq2AzBo6rcgd@infradead.org \
--to=hch@infradead.org \
--cc=a.hindborg@samsung.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmi@metaspace.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.