Re: [PATCH 1/1] USB: serial: option: add Telit generic core-dump composition

[Johan Hovold <johan@kernel.org>]

On Thu, May 30, 2024 at 10:00:53AM +0200, Daniele Palmas wrote:
> Add the following core-dump composition, used in different Telit modems:
> 
> 0x9000: tty (sahara)
> T:  Bus=03 Lev=01 Prnt=03 Port=07 Cnt=01 Dev#= 41 Spd=480  MxCh= 0
> D:  Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1bc7 ProdID=9000 Rev=00.00
> S:  Manufacturer=Telit Cinterion
> S:  Product=FN990-dump
> S:  SerialNumber=e815bdde
> C:  #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=2mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=10 Driver=option
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> 
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> ---
>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 8a5846d4adf6..a58dd4ef461b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1433,6 +1433,8 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = NCTRL(2) },
>  	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x701b, 0xff),	/* Telit LE910R1 (ECM) */
>  	  .driver_info = NCTRL(2) },
> +	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x9000, 0xff),	/* Telit generic core-dump device */
> +	  .driver_info = NCTRL(0) },

ZLP not needed like for the other flashing device entries?

>  	{ USB_DEVICE(TELIT_VENDOR_ID, 0x9010),				/* Telit SBL FN980 flashing device */
>  	  .driver_info = NCTRL(0) | ZLP },
>  	{ USB_DEVICE(TELIT_VENDOR_ID, 0x9200),				/* Telit LE910S1 flashing device */

Johan