All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-pci@vger.kernel.org,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: Re: [pci:controller/rockchip 11/11] drivers/pci/controller/dwc/pcie-dw-rockchip.c:491:undefined reference to `pci_epc_init_notify'
Date: Thu, 27 Jun 2024 10:51:10 +0200	[thread overview]
Message-ID: <Zn0n_qvyd47Aw65E@ryzen.lan> (raw)
In-Reply-To: <Zn0j1LrkLELW0fO1@ryzen.lan>

On Thu, Jun 27, 2024 at 10:33:24AM +0200, Niklas Cassel wrote:
> 
> Perhaps the smartest thing right now is to just recreate the
> pci/controller/rockchip branch, by:
> 1) reset the rockchip branch to v6.10-rc1
> 2) merge the pci/controller/dwc branch to the rockchip branch
> 3) merge the pci/endpoint branch to to the rockchip branch
> 4) pick all the patches that are currently on the pci/controller/rockchip
> 5) squash: 246afbe0f6fc ("PCI: dw-rockchip: Use pci_epc_init_notify() directly")
>    into the commit that adds dw-rockchip endpoint mode support
>    (9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support"))
> 6) squash: https://lore.kernel.org/linux-pci/20240626191325.4074794-2-cassel@kernel.org/
>    into the commit that adds dw-rockchip endpoint mode support
>    (9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support"))
> 
> 
> This way:
> - All commits will build as individual patches, so no build errors from the
>   test robot (even when it builds a patch that is in the middle (e.g. 10/11)).
> - Even if futher commits are applied to pci/controller/dwc or pci/endpoint,
>   we will not depend on any newly applied patches to these branches, so there
>   will be no need to "re-merge" the branches to the rockchip branch.

The end result would look like this:
https://github.com/floatious/linux/commits/dw-rockchip-remerge-example/

(Just in case you want to git diff to see that we did the same thing...)


Kind regards,
Niklas

  reply	other threads:[~2024-06-27  8:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 23:54 [pci:controller/rockchip 11/11] drivers/pci/controller/dwc/pcie-dw-rockchip.c:491:undefined reference to `pci_epc_init_notify' kernel test robot
2024-06-27  8:33 ` Niklas Cassel
2024-06-27  8:51   ` Niklas Cassel [this message]
2024-06-28  0:27     ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zn0n_qvyd47Aw65E@ryzen.lan \
    --to=cassel@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.