Re: [Buildroot] [PATCH] package/slang: fix patch fuzz

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dario, All,

On 2024-06-25 13:56 +0200, Dario Binacchi spake thusly:
> From: "Yann E. MORIN" <[5]yann.morin@orange.com>
> > Since commit 8f88a644ed7d (support/scripts/apply-patches.sh: set the
> > maximum fuzz factor to 0), we no longer accept fuzz in patches. Before
> > 8f88a644ed7d was applied, alot of patches were fixed in preparatory
> > commits, but slang was missed (although the patch has been present since
> > 2017.
> what configuration does contain this package?

I've devised a little script that finds almost all packages that have
patches, and test they can be downloaded and patched:

    #!/usr/bin/env bash
    export BR2_DL_DIR=$(pwd)/meh-dl
    make defconfig
    ./utils/config --set-str BR2_BACKUP_SITE ""
    # Ignore boot/ and linux/ as they are too special...
    find package/ -type f -name '*.mk' -printf '%h\n' \
    |sort -u \
    |while read dir; do
        [ -e "${dir}/Config.in" ] || continue
        ( find "${dir}" -type f -name '*.patch' -print -quit |grep -q . ) || continue
        pkg="$( basename "${dir}" )"
        [ -e "${dir}/${pkg}.mk" ] || continue
        sed -r -e '/^\$\(eval \$\((host-)?[^-]+-package\)\)$/!d; s//\1'"${pkg}"'/' "${dir}/${pkg}.mk"
    done \
    |while read pkg; do
        if ! make "${pkg}-patch"; then
            echo "${pkg}" >> fuzz.lst
        fi
    done

Them we've a bit of hand-guessing and the build log, here's what I could
conclude:

Fuzz errors:
  - cpulimit                    - crda                        - dahdi-tools
  - eigen                       - empty                       - exim
  - ficl                        - flite                       - freeradius-server
  - freerdp                     - imx-kobs                    - imx-vpu-hantro
  - gpm                         - grpc                        - haserl
  - janus-gateway               - leveldb                     - libblockdev
  - libfcgi                     - libcrypt                    - libgdiplus
  - libglfw                     - libhid                      - liblinear
  - libmad                      - libnfs                      - libsoup
  - libssh2                     - libsvg                      - libsvgtiny
  - libtheora                   - libtorrent                  - libyuv
  - clang                       - lxc                         - mediastreamer
  - memstat                     - mongrel                     - monit
  - ncmpc                       - nmap                        - nushell
  - nvidia-driver               - oatpp                       - openvmtools
  - paxtest                     - poke                        - pulseview
  - python-pybind               - qt5webkit                   - rdesktop
  - redis                       - rrdtool                     - rt-tests
  - rygel                       - sane-backends               - sdl_mixer
  - shairport-sync              - snort                       - sox
  - sunxi-mali-utgard-driver    - sylpheed                    - udpcast
  - vtun                        - wlroots                     - xdriver_xf86-video-mach64
  - xdriver_xf86-video-tdfx     - xfsprogs                    - yajl
  - ympd

Hash errors:
  - am335x-pru-package          - cgic                        - daq
  - dvb-apps                    - latencytop                  - linknx
  - linux-fusion                - lite                        - mimic
  - resiprocate                 - w_scan

Download errors:
  - aumix: 403 forbidden        - bsdiff: 403 forbidden       - dillo: 404
  - fbset: 410 Gone             - gamin: 404                  - giblib: 404
  - httping: 404                - libtorrent: 404             - live5: 404
  - lugaru: 404                 - matchbox-lib: 400 ???       - mpir: upstream DNS gone
  - qt5enginio: 404             - quagga: 404                 - racehound: 404
  - rp-pppoe: 404               - rtorrent: 404               - sysprof: 404
  - taskd: 404                  - trinity: TCP timeout        - zabbix: 404
  - xenomai: 404

Config issues:
  - aufs-util: needs a kernel

Of course, the hash, download, and config issues are not caused by the
fuzz restriction, which I still believe was a very good thing to do! :-)
Still, they may hide a few fuzz issues.

Anyway, the list is up for all to pick a package and help fix that as a
collective effort.

Bonus points for anyone that confirms the corner cases: binutils, gcc,
gdb, and a few others, which have a version choice... Or linux, which
has a conditional patch (Aha!) and a version with a patch... Of any of
the bootloaders, some of whioch have a version coice as well...

I think I'll be having a look at all the hash errors, but anyone is free
to look at them and post a patch that fixes the hash and explains the
issue...

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot