From: Michal Hocko <mhocko@suse.com>
To: xiujianfeng <xiujianfeng@huawei.com>
Cc: hannes@cmpxchg.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm: memcg: adjust the warning when seq_buf overflows
Date: Fri, 28 Jun 2024 10:15:00 +0200 [thread overview]
Message-ID: <Zn5xBNY-Z4eNTCAL@tiehlicka> (raw)
In-Reply-To: <0e44be2c-7039-710b-202f-c452bfc3f1ad@huawei.com>
On Fri 28-06-24 16:09:02, xiujianfeng wrote:
>
>
> On 2024/6/28 15:45, Michal Hocko wrote:
> > On Fri 28-06-24 07:23:33, Xiu Jianfeng wrote:
> >> Currently it uses WARN_ON_ONCE() if seq_buf overflows when user reads
> >> memory.stat, the only advantage of WARN_ON_ONCE is that the splat is
> >> so verbose that it gets noticed. And also it panics the system if
> >> panic_on_warn is enabled. It seems like the warning is just an over
> >> reaction and a simple pr_warn should just achieve the similar effect.
> >>
> >> Suggested-by: Michal Hocko <mhocko@suse.com>
> >> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> >
> > Acked-by: Michal Hocko <mhocko@suse.com>
> >
> > I would just squash this with other patch removing it from
> > memcg_stat_format. But this is up to you.
>
> Sorry, I might have misunderstood, if you can squash them, it looks good
> to me, thanks.
Andrew usually can do that even when the patch is in his tree. But as
I've said having 2 patches is ok as well.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2024-06-28 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 7:23 [PATCH -next] mm: memcg: adjust the warning when seq_buf overflows Xiu Jianfeng
2024-06-28 7:45 ` Michal Hocko
2024-06-28 7:55 ` xiujianfeng
2024-06-28 8:09 ` xiujianfeng
2024-06-28 8:15 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn5xBNY-Z4eNTCAL@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.