From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: testunit: don't erase registers after STOP
Date: Fri, 28 Jun 2024 20:40:37 +0200 [thread overview]
Message-ID: <Zn8DpYNh20oWr-RV@shikoro> (raw)
In-Reply-To: <20240627111445.29751-5-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Thu, Jun 27, 2024 at 01:14:47PM +0200, Wolfram Sang wrote:
> STOP fallsthrough to WRITE_REQUESTED but this became problematic when
> clearing the testunit registers was added to the latter. Actually, there
> is no reason to clear the testunit state after STOP. Doing it when a new
> WRITE_REQUESTED arrives is enough. So, no need to fallthrough, at all.
>
> Fixes: b39ab96aa894 ("i2c: testunit: add support for block process calls")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-06-28 18:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 11:14 [PATCH 0/2] i2c: testunit: regression fixes Wolfram Sang
2024-06-27 11:14 ` [PATCH 1/2] i2c: testunit: don't erase registers after STOP Wolfram Sang
2024-06-27 15:15 ` Andi Shyti
2024-06-28 18:40 ` Wolfram Sang [this message]
2024-06-27 11:14 ` [PATCH 2/2] i2c: testunit: discard write requests while old command is running Wolfram Sang
2024-06-27 15:21 ` Andi Shyti
2024-06-28 18:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zn8DpYNh20oWr-RV@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.