Re: [PATCH v17 04/20] libtasn1: changes for grub compatibility - Daniel Kiper via Grub-devel

From: Daniel Kiper via Grub-devel <grub-devel@gnu.org>
To: Gary Lin <glin@suse.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
	The development of GNU GRUB <grub-devel@gnu.org>,
	Hernan Gatta <hegatta@linux.microsoft.com>,
	Daniel Axtens <dja@axtens.net>,
	shkhisti@microsoft.com, jaskaran.khurana@microsoft.com,
	christopher.co@microsoft.com, daniel.mihai@microsoft.com,
	jaredz@redhat.com, development@efficientek.com,
	jejb@linux.ibm.com, mchang@suse.com, patrick.colp@oracle.com,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v17 04/20] libtasn1: changes for grub compatibility
Date: Mon, 17 Jun 2024 17:12:12 +0200	[thread overview]
Message-ID: <ZnBSTMHyviMHoRef@tomti.i.net-space.pl> (raw)
In-Reply-To: <20240614064553.21614-5-glin@suse.com>

On Fri, Jun 14, 2024 at 02:45:37PM +0800, Gary Lin wrote:
> Based on the patch from "Daniel Axtens <dja@axtens.net>"
>
> Do a few things to make libtasn1 compile as part of grub:
>
>  - remove _asn1_strcat and replace strcat with the bound-checked
>    _asn1_str_cat except the one inside _asn1_str_cat. That strcat is
>    replaced with strcpy.
>
>  - adjust header paths in libtasn1.h
>
>  - replace a 64 bit division with a call to grub_divmod64, preventing
>    creation of __udivdi3 calls on 32 bit platforms.

This patch should be split into three separate patches.

I think this and other libtasn1 fixes should have
"Signed-off-by: Daniel Axtens <dja@axtens.net>" here.

> Signed-off-by: Gary Lin <glin@suse.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel