From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A854C9A for ; Tue, 18 Jun 2024 13:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718718284; cv=none; b=n33qV8wnBOos4lZtymUT+1Vw0fqHBV4z/nHZAiBJuO1BcfJZzsiPs+u0MyiEHcTEqCjt7msYNM045kGcY9ZzP/a0qDcDDK0hlt4EFlsJleWyD4s/BIK3P+RKXu6wFyhup20CdCjwSUCKqG66RYmjM6rOZl+DxUQqAcXKnmAYjb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718718284; c=relaxed/simple; bh=ucoJYhoxF3OeIUrNTD5OVc9wJ2+UwD/QG8mQFRwwwDM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=QeeeT8PaeY2P3MSDHkn+LuYJ9bw6014fk2Np5M4NvaFMbhbZhOgL9PjCegjS6x2zpMcwDhbtV3kJ/TbStfcmu+DnCqpSB0K1WesJwdU4Qfa1mDgkFp4Uk9o/kQJolghi7Aw6bXXcYpeaC0DA2fHGBYE3IDLZVb9g6EbVOi2ZEwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qoNaCQ7G; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qoNaCQ7G" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-632b6ff93e4so74436827b3.1 for ; Tue, 18 Jun 2024 06:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718718281; x=1719323081; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ajIYhMIotUty+XQ9bziyo1SmPKA7CkPdKzruWtPxrXM=; b=qoNaCQ7Gi144Jb1RXnltAkOFcjFQnWIn1WHGnFN6ojwZ3HG46jE+3A4S2cyQpTzF2u BCa+/XK+G4TvEDU/86UXxZMRqwsg+By7bzDhP72VG4JjUHZ75CCuHcjYKLE6IEy4y5f1 Alt5qiIr7nbKebxL9rdmNGcUUj4cOG9ATPefNgY6L9ROSOJVmpgDIhwkNnf3y6jiE1GW Q8xFrDUWkx1CPwzTTTDLkBqbiQMCpVE6MJR7HHW5veA3x/m+d0PS3+pMBz8p78g0/1nF DDY7whZ8YxGoc/lPDFmrQuPx1S7VeYx8GdWm/+/kk1RftiOc7b7rNmP8qKSyFyOo4oYP aleQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718718281; x=1719323081; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ajIYhMIotUty+XQ9bziyo1SmPKA7CkPdKzruWtPxrXM=; b=uDlHyZiRf7lPmkzTo4gRMaujDDAAiMFnnn9ojXmQAhTzRY/B1YtpNMJTccc8U9NWLn /RFpf7m/dr6Ng3L/q7YBuTn1rh/PREiZAFd3g7TXpMNdVG62pWmZ3pcun0A9niAmPLlt x9I8ewFVKybx6a3RcqRdlxfQjyOzHbhZcD+No1B3IHum4BOYSwX5eTXEfWZ3usaa1Pwa kYqQfKjcZ18x+mE844OklosZ8gQN0zOHtM2xFuH/8tx38wLsiZSn28Q4ytrHLo+jj3qd V4Mo9iY1AveqfzWGAvz6KCpagVpJp+h3RauyaecJp62jgEnvI9LvF+QN+WZHhUCwhuRx 4VfA== X-Forwarded-Encrypted: i=1; AJvYcCXO2zGfdBHwDXonJfWYZJ1KYg9GExYVY3yW7PSspAoZCS3esQnwK+O4zuh83eGPH59EfCBLl/bEP6wXAhJsMW+zcqtU X-Gm-Message-State: AOJu0YwgcbnE/uWb9aebJWsb0LVLQfg0XrlMwBGZ4GnT/SZM8L2ksBnV nReEooVN3TCA1tPriSfKi/d40DkXX58SOp2CmztA8PmyIlNuqV2a0xQuJaTq7TitfWOR0T1E+eE V4g== X-Google-Smtp-Source: AGHT+IEnC2RZHpd6Y9tdhSA2DQFR1PTXG4Zn4Jr9j7XgXE4mUhJjCsEw3I9TdBvA0MYws19u54WEIg0A0M8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:2b0f:b0:dda:c57c:b69b with SMTP id 3f1490d57ef6-dff150de181mr4007095276.0.1718718281572; Tue, 18 Jun 2024 06:44:41 -0700 (PDT) Date: Tue, 18 Jun 2024 06:44:40 -0700 In-Reply-To: <20240618102434.GDZnFgYsJHTGibyuX1@fat_crate.local> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240617210432.1642542-1-seanjc@google.com> <20240617210432.1642542-4-seanjc@google.com> <20240618102434.GDZnFgYsJHTGibyuX1@fat_crate.local> Message-ID: Subject: Re: [PATCH 3/3] KVM: SVM: Use compound literal in lieu of __maybe_unused rdmsr() param From: Sean Christopherson To: Borislav Petkov Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Jun 18, 2024, Borislav Petkov wrote: > > + rdmsr(MSR_TSC_AUX, sev_es_host_save_area(sd)->tsc_aux, (u32){0}); > > > > return 0; > > } > > -- > > Right, slick, but I'd argue that before it was better because __maybe_unused was > actually documenting why that var is there. > > (u32){} looks a bit more cryptic but meh, ok, I guess. Yeah, I'm 50/50 on whether it's too clever. I'm totally fine keeping msr_hi, what I really want to do is rewrite the rdmsr() macros to return values :-/