From: Sean Christopherson <seanjc@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
kernel test robot <lkp@intel.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH] x86/alternatives, kvm: Fix a couple of CALLs without a frame pointer
Date: Tue, 18 Jun 2024 16:19:48 -0700 [thread overview]
Message-ID: <ZnIWFHYipU2DsLK6@google.com> (raw)
In-Reply-To: <20240618200539.GHZnHok3nr60R4BXSK@fat_crate.local>
On Tue, Jun 18, 2024, Borislav Petkov wrote:
> Ok, I was able to scratch up this from the whole shebang:
>
> ---
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> Date: Tue, 18 Jun 2024 21:57:27 +0200
>
> objtool complains:
>
> arch/x86/kvm/kvm.o: warning: objtool: .altinstr_replacement+0xc5: call without frame pointer save/setup
> vmlinux.o: warning: objtool: .altinstr_replacement+0x2eb: call without frame pointer save/setup
>
> Make sure rSP is an output operand to the respective asm() statements.
>
> The test_cc() hunk courtesy of peterz. Also from him add some helpful
> debugging info to the documentation.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406141648.jO9qNGLa-lkp@intel.com/
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> ---
Feel free to take this through tip, I'll be flabbergasted if someone sends a patch
that modifies test_cc().
Acked-by: Sean Christopherson <seanjc@google.com>
next prev parent reply other threads:[~2024-06-18 23:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 8:15 [tip:x86/alternatives 14/14] arch/x86/kvm/kvm.o: warning: objtool: .altinstr_replacement+0xc5: call without frame pointer save/setup kernel test robot
2024-06-14 15:22 ` Borislav Petkov
2024-06-14 15:35 ` Sean Christopherson
2024-06-14 15:58 ` Borislav Petkov
2024-06-15 8:09 ` Borislav Petkov
2024-06-17 14:39 ` Sean Christopherson
2024-06-18 10:42 ` Peter Zijlstra
2024-06-18 10:47 ` Peter Zijlstra
2024-06-18 20:05 ` [PATCH] x86/alternatives, kvm: Fix a couple of CALLs without a frame pointer Borislav Petkov
2024-06-18 23:19 ` Sean Christopherson [this message]
2024-06-18 14:24 ` [tip:x86/alternatives 14/14] arch/x86/kvm/kvm.o: warning: objtool: .altinstr_replacement+0xc5: call without frame pointer save/setup Sean Christopherson
2024-06-18 14:47 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnIWFHYipU2DsLK6@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.