From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Chandan Babu R <chandanbabu@kernel.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: honor init_xattrs in xfs_init_new_inode for !attr && attr2 fs
Date: Tue, 18 Jun 2024 22:25:49 -0700 [thread overview]
Message-ID: <ZnJr3fKw42EP9gPW@infradead.org> (raw)
In-Reply-To: <20240619010622.GI103034@frogsfrogsfrogs>
On Tue, Jun 18, 2024 at 06:06:22PM -0700, Darrick J. Wong wrote:
> NAK, this patch is still not correct -- if we add an attr fork here, we
> also have to xfs_add_attr(). ATTR protects attr forks in general,
> whereas ATTR2 only protects dynamic fork sizes.
Yes. Note that I was kinda surprised we wouldn't always set the attr
bit by default in mkfs, but indeed we can create a file system without
attrs, which felt odd.
next prev parent reply other threads:[~2024-06-19 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 23:21 [PATCH] xfs: honor init_xattrs in xfs_init_new_inode for !attr && attr2 fs Darrick J. Wong
2024-06-19 1:06 ` Darrick J. Wong
2024-06-19 5:25 ` Christoph Hellwig [this message]
2024-06-19 16:00 ` Darrick J. Wong
2024-07-01 1:27 ` Dave Chinner
2024-07-01 23:37 ` Darrick J. Wong
2024-07-12 0:31 ` Dave Chinner
2024-07-12 5:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnJr3fKw42EP9gPW@infradead.org \
--to=hch@infradead.org \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.