From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C73ECC27C53 for ; Wed, 19 Jun 2024 11:38:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A05A210EC67; Wed, 19 Jun 2024 11:38:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZHF1cEfx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 58C1F10EC5A; Wed, 19 Jun 2024 11:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718797104; x=1750333104; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=OzgJd0fZdmopDq1yIr6OCKccv3DQY6JfMSa1OEMY9S4=; b=ZHF1cEfx0HTbiUC5JxpbFPqgnKkiRKRJNwc9k+IjiyTJgfvub+JNCQmr w7lL44xsLnaVn9BG7AFTnJpnOdnSqnv09x8nDWYClhbXIQwO+74i/VTEr GtV4mYNYUNOVHRoixk/3MwAknXMFH0vWPLmE8Fvk6dzQJB9H+9C9OkH1S HxPdeIdA4GNTC+VRoxcOLiFUSCXo3/J4OzrOorEFOTbfHsAw54r7bSWRx xiZZHXV8+scjJYC9zS34S9TgkcwsgIj/QI+Do2X2cvSuBhJTZ0znr3a+d ZLDrFxDu00REaWTg6DeYg5uR2b4zdqvZwW1Gfdmhotq129j4cEFKBL61H g==; X-CSE-ConnectionGUID: 3BE5YEL/QDy262ztoyBU6g== X-CSE-MsgGUID: 2/IsF4srQiqu08WNtEuITQ== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="33277066" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="33277066" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 04:38:20 -0700 X-CSE-ConnectionGUID: e8a6O59DSLeNzAV4pCaTSA== X-CSE-MsgGUID: 5ngR9g3sQuy56aKBG1PX2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="41847286" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 19 Jun 2024 04:38:17 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 19 Jun 2024 14:38:16 +0300 Date: Wed, 19 Jun 2024 14:38:16 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi Subject: Re: [PATCH v2 0/9] drm/i915: Polish plane surface alignment handling Message-ID: References: <20240612204712.31404-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240612204712.31404-1-ville.syrjala@linux.intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jun 12, 2024 at 11:47:03PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_surf_alignment() in particular has devolved into > a complete mess. Redesign the code so that we can handle > alignment restrictions in a nicer. Also adjust alignment > for TGL+ to actually match the hardware requirements. > > v2: Drop the per-plane vma stuff as it was borked > Don't temporarily remove the 2MiB DPT alignment for UV on TGL > > Ville Syrjälä (9): > drm: Rename drm_plane_check_pixel_format() to drm_plane_has_format() > drm: Export drm_plane_has_format() Maarten/Maxime/Thomas, can I get an ack for merging these via drm-intel please? > drm/i915: Introduce the plane->min_alignment() vfunc > drm/i915: Introduce fb->min_alignment > drm/i915: Split cursor alignment to per-platform vfuncs > drm/i915: Split pre-skl platforms out from intel_surf_alignment() > drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c > drm/i915: Update plane alignment requirements for TGL+ > drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff > > drivers/gpu/drm/drm_atomic.c | 7 +- > drivers/gpu/drm/drm_crtc.c | 6 +- > drivers/gpu/drm/drm_crtc_internal.h | 2 - > drivers/gpu/drm/drm_plane.c | 23 ++- > drivers/gpu/drm/i915/display/i9xx_plane.c | 75 ++++++++- > drivers/gpu/drm/i915/display/intel_cursor.c | 38 +++++ > .../drm/i915/display/intel_display_types.h | 5 + > drivers/gpu/drm/i915/display/intel_fb.c | 151 ++++-------------- > drivers/gpu/drm/i915/display/intel_fb.h | 3 - > drivers/gpu/drm/i915/display/intel_fb_pin.c | 39 +++-- > drivers/gpu/drm/i915/display/intel_fb_pin.h | 3 +- > drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +- > drivers/gpu/drm/i915/display/intel_sprite.c | 26 +++ > .../drm/i915/display/skl_universal_plane.c | 85 +++++++++- > drivers/gpu/drm/xe/display/xe_fb_pin.c | 3 +- > drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 +- Lucas, can you give me an ack for the merging the xe changes via drm-intel? > include/drm/drm_plane.h | 2 + > 17 files changed, 309 insertions(+), 168 deletions(-) > > -- > 2.44.2 -- Ville Syrjälä Intel