From: Sudeep Holla <sudeep.holla@arm.com>
To: Youwan Wang <youwan@nfschina.com>
Cc: lpieralisi@kernel.org, guohanjun@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org,
rafael@kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI / amba: Drop unnecessary check for registered amba_dummy_clk
Date: Thu, 20 Jun 2024 09:38:18 +0100 [thread overview]
Message-ID: <ZnPqeniNlw74MW-S@bogus> (raw)
In-Reply-To: <20240620005930.295880-1-youwan@nfschina.com>
On Thu, Jun 20, 2024 at 08:59:30AM +0800, Youwan Wang wrote:
> amba_register_dummy_clk() is called only once from acpi_amba_init()
> and acpi_amba_init() itself is called once during the initialisation.
> amba_dummy_clk can't be initialised before this in any other code
> path and hence the check for already registered amba_dummy_clk is
> not necessary. Drop the same.
>
You are not reading my response correctly and fixing all the issues.
1. You had v3 and now this is again v1 ? Perhaps v4 ?
2. You missed to add my Acked-by which I gave to your v2
3. This is v4 and new reviewers of this patch have absolutely no idea
what got changed from v1->v2->v3->v4. It is always good to add change
log describing what changed across these versions
4. I asked you to add ARM64 maintainers as we would request them to pick
this up via ARM64 tree.
Catalin Marinas <catalin.marinas@arm.com
Will Deacon <will@kernel.org>
I will ignore your patches if these are not fixed, I have told you same
thing twice now.
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-06-20 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 0:59 [PATCH] ACPI / amba: Drop unnecessary check for registered amba_dummy_clk Youwan Wang
2024-06-20 8:38 ` Sudeep Holla [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-18 11:58 [PATCH v3] ACPI /amba: Fix meaningless code for amba_register_dummy_clk() Youwan Wang
2024-06-20 13:37 ` [PATCH] ACPI / amba: Drop unnecessary check for registered amba_dummy_clk Youwan Wang
2024-06-24 2:09 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnPqeniNlw74MW-S@bogus \
--to=sudeep.holla@arm.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=youwan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.