From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 662F9C27C4F for ; Sat, 22 Jun 2024 00:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ElKI85UTs1p04DwkUxeH9mqP0Rg0zIEmKqJiWvIGcE=; b=nK1Yr3vjq39dY2 lZcPG8qWPT4itx/fI0CHXbgd/3exgqnr4GeJHUqPwS0T1rQK6Rimgb9SchoGXdFuKOl4Yrq2rVViZ noFqOyCM/rdlz3AqBHOIgZ7zCWP/qKx8JwY++tBJF9vVF1VQw2ga3/qtYrhv79li1DSU66MpdxsV9 JGugfqUSUEGh9XfzNr2+EpCt/vj4Ukno8HufZPt8lxrKmwziYGUFgVj6reP1wuSECug+fa3wjEdFJ HeRqCzbOfuJkSbyGqZFa6Fu1KK0PHZiU8FHlkQAHZrDAkaJJgZYj9cYL1fUrv+rzsu80zb6lPPfYz IxIUwDheBu69CKp8QcHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKoHN-0000000AxzV-0DxV; Sat, 22 Jun 2024 00:06:53 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKoHH-0000000AxvW-1Zjk for linux-phy@lists.infradead.org; Sat, 22 Jun 2024 00:06:48 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1f70fdc9645so222775ad.1 for ; Fri, 21 Jun 2024 17:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719014806; x=1719619606; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=q57qs1b7mti7OZV/FcLWYOEHaACY1juoHvOEv2DBmzUWTyvovMXnPLFuAElPlYHoOY vzmV7gMVsB/PyWPdofnNVw4j7gpZ/ccPMRm2RKgKKnqhQKJBRk++sUCPRaflXNXrUZk7 uMgs/XMZMUiwDZsqr81GVXf9TWtzCvMIY9JgPjg/LKQDxysqSvx1B+Ia/6UmnXyVGb8Y NNDjI60UKHvKaeZNGdPHDJ8Ql9OhNb5bBQkNknmzJ0n0zezxNntMFK2ra3GaT6qyzfSY tykzJAm8ZJzGqnBbnmooV8Oc2g2LCY3FOPHsTTqJkM5LWmHo4bvsHOBSjEIsQOt07VuU +4Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719014806; x=1719619606; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=Tq7OpUwi8C8/xJ1XfAs14rPs7DGfIqS+csQtZeNPNyw9+713RyGWVrhyC2iS8bKm5m QbDN+95gCJw3eOfNIaD34tpcoHctfCwbs3eg2x/mBm1pi66EeW8Qxg4rRr7MpeniA+UZ 3um/o5KDyQtExnomvHqBl/sTO2LZufip4Bigx3IJwSRbMEKOevrPp5ZZNgxnB+hF2A35 Su/ZwBr67xVbIs0oD6v+7rPQlSPr1G9nytZxSpT6rvK+zeOl0PxWRibL3CKefA6TETKG ik9iaIja/ed4TMnaK2x9DkbzxmdlEUQQKSmm+l9dmteLlZPLutnIZ6vQSUD2qGkB/gIe k+qQ== X-Forwarded-Encrypted: i=1; AJvYcCUMnywP9Zi1FdbuIe310y0aQVL3s1VI6fz/hCulIVWvDEVvQwUw1JmJsqZGOcy/zajYPr5+pw4ArrhTdYObAX456YGlouDoWvyvAH/nPQ== X-Gm-Message-State: AOJu0YxgF4dpJ4/gbmSPvCsJOv95VIrq9m+1AFm1WBcCwQkC4e1izlZi nT105rNmG5OuOvWAOWZY2X7JA1BaZVzPWHD0rI+1a6+cy2ixVedKWqpQRQB71Q== X-Google-Smtp-Source: AGHT+IH2DpcqGgyH+HjMIKHYfMU0Aprz6jSxhq9kEXfnCX/pqvkRFp0LybPg6McZN0Dup2hfAWO3ng== X-Received: by 2002:a17:902:7689:b0:1f9:bc99:d94a with SMTP id d9443c01a7336-1fa09ff2e18mr845625ad.5.1719014806175; Fri, 21 Jun 2024 17:06:46 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-706512d6088sm2058052b3a.175.2024.06.21.17.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 17:06:45 -0700 (PDT) Date: Fri, 21 Jun 2024 17:06:42 -0700 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 5/6] phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk Message-ID: References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_170647_461779_E9EA171E X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 06/17/2024, Andr=E9 Draszik wrote: > Using the regulator_bulk APIs, the handling of power supplies becomes > much simpler. There is no need anymore to check if regulators have been > acquired or not, the bulk APIs will do all the work for us. We can also > drop the various handles to the individual power supplies in the driver > runtime data and instead simply treat them all as one thing. Error > cleanup also becomes much simpler. > = > Converting to the regulator_bulk APIs also makes it easier to add > support for those SoCs that have additional power supplies for the PHY. > Google Tensor gs101 is one example of such a SoC. Otherwise we'd have > to add all additional supplies individually via individual calls to > regulator_get() and enable/disable handle them all individually, > including complicated error handling. That doesn't scale and clutters > the code. > = > Just update the code to use the regulator_bulk APIs. > = > Signed-off-by: Andr=E9 Draszik Tested-by: Will McVicker [...] Thanks, Will -- = linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B92979FE for ; Sat, 22 Jun 2024 00:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719014808; cv=none; b=LX+2kX9P+P0UggRf3Yi3Lt/Y0zwbjGia71PU7qGWjUSe1n2rwSLFsb6mdSzWsI3NIPJCWVjXoD5JmeL4ZT20/gJYV8LuhrlAOWembhY2RRNjqS0O2zH0JaJMYORb44Gdb/JyIIvoVqhqtx07V1n08QzS6voZgXCa5NqxieX4uLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719014808; c=relaxed/simple; bh=2iZCdobCesQIlaIFBjwhULiIkRQI8wcQ8QBqpcXuLO4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=abbe2wv2NGqkk/XI8mn4a2MtAzwThSFwHrfyPF7hRbMye/s9hKUZHhkI/4nIxfdI3rSUmiHa56VHy+kjXEHAkzF5Koo7SmJ1QbR2EIGleKL9vM8U+bl9Aj3bIFl6gomyZOn0HLUF9fcCJ+DVRrrNsoioQuCbWpTpQYsFc4wd9d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q4Xqf3sj; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q4Xqf3sj" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1f70fdc9645so222745ad.1 for ; Fri, 21 Jun 2024 17:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719014806; x=1719619606; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=q4Xqf3sjKt+6bs4X7412Tauxe8ZK75EWtXsyRXywJc65KD8yLHzAD7rS696c8rb2ww fyPIiIuPS40v5fDaJC98Dkj//vuZVAtv/DYXUUvHJH9XEexB9TPzCe17YW5hPGd8o/g1 9DsxDex6z78ncsuRV8YQtbbVHaV78oGG0FZM/IlHW9NKX83lkjQ8cOfgh67UmXR561Gk g+ClmliAzy0lnmi8Fq4OwCWfrH4SVw3sFtDoMWwK8Bp8yrboM/pI3i1IWtIxcQK/W89H 3FyuZDlJU83e03n6FFxZEEy6gncSesDECTyiIMc2+PKjFAV+rx1fs5d1vIR/txVIB026 Qisw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719014806; x=1719619606; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=50aRBwML1alf49hO+1BmWw804OZfmi02o/xT006me7w=; b=ojZVBHtEL+OsBcBUe7n9pGJkRzU/glT6F74sUr/7IZ/j+nMB6a8pck6fcwNtv+M3+5 q+1orBYYtAXebQ7PvgOVKWFbXNZZFCL4gmJQ2S+tPqpFK7RwOIvHxyth3IW2f/vMB4Qe FuODu7ObZZF9eO0hC/lPrxZgXfGv70h+AgQmn5DopeNS69tcaJZKZyh9URqA72DKXIIP VfptdnxQyWCjwZyigmICtR+dTvoO0f8nBFz9Dmbyy7q8hsVJaIrKvyaDUbkiG88nhW6D sIcJht9FpUV4nyMb+r4PtHHPLly+2EM0kxP+CDpelB/vaV1XGz7dngD69YcBdLpSEaYv eEqw== X-Forwarded-Encrypted: i=1; AJvYcCXMePkeryD7SMlK6iylJIXPGhab3Wqq6wpwqhs+qWvTUeWR6MVkAeHjLMGXVgrjScPckmLJpYHs8LTwsNo6HOg3W/yoQGP3r5/0qIJmhhQr3DU= X-Gm-Message-State: AOJu0YzfK0Qhb7rsh5G6trEN6K+DDQW7yF3ZmjqJw4Ddht4ZA26rPO00 RnHmFFZkpye1Z7NupDur4apAhHGcHTXl6fcDTrTbvRLs5KIckallCHARp4J36A== X-Google-Smtp-Source: AGHT+IH2DpcqGgyH+HjMIKHYfMU0Aprz6jSxhq9kEXfnCX/pqvkRFp0LybPg6McZN0Dup2hfAWO3ng== X-Received: by 2002:a17:902:7689:b0:1f9:bc99:d94a with SMTP id d9443c01a7336-1fa09ff2e18mr845625ad.5.1719014806175; Fri, 21 Jun 2024 17:06:46 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-706512d6088sm2058052b3a.175.2024.06.21.17.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 17:06:45 -0700 (PDT) Date: Fri, 21 Jun 2024 17:06:42 -0700 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 5/6] phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk Message-ID: References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617-usb-phy-gs101-v3-5-b66de9ae7424@linaro.org> On 06/17/2024, André Draszik wrote: > Using the regulator_bulk APIs, the handling of power supplies becomes > much simpler. There is no need anymore to check if regulators have been > acquired or not, the bulk APIs will do all the work for us. We can also > drop the various handles to the individual power supplies in the driver > runtime data and instead simply treat them all as one thing. Error > cleanup also becomes much simpler. > > Converting to the regulator_bulk APIs also makes it easier to add > support for those SoCs that have additional power supplies for the PHY. > Google Tensor gs101 is one example of such a SoC. Otherwise we'd have > to add all additional supplies individually via individual calls to > regulator_get() and enable/disable handle them all individually, > including complicated error handling. That doesn't scale and clutters > the code. > > Just update the code to use the regulator_bulk APIs. > > Signed-off-by: André Draszik Tested-by: Will McVicker [...] Thanks, Will