From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD39B82492; Sat, 22 Jun 2024 13:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719063587; cv=none; b=U1m8kSiie3QcBp+38xvlvbO8J3MuBngo+dUhqmljBkL0vNDi12R36K7brarfTiPX52RkC3ltlrX/tjKe3kzzUpmQoJVq9cWkeULfcBsEElpUJ9HrFruxqpE6NInfgN2Lt1QISJtS6D7mqHdO0NH4TJaqymHVCVirU7owVeZ/l5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719063587; c=relaxed/simple; bh=XoDceAdXs9z6NeEt0iuTL63LGCFyCmlS+FZp9Eo478A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XfmLfb14kNFBkamwkDTiiT6uWm7R8+YVbaUiImXEAIniKutHG8rNWxdNDGc7BMoEhRqS20dT5O1jviDJW8yw30SEgBOfK1f8stW8nVgkePHLUBhS4KTYNdei/n8iRCAeiM5X2hExAuBybdy81XGVnaCVlNAIGje0mP7KqgZbE5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YRyrbmEZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YRyrbmEZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 864CAC3277B; Sat, 22 Jun 2024 13:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719063587; bh=XoDceAdXs9z6NeEt0iuTL63LGCFyCmlS+FZp9Eo478A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRyrbmEZwPVx6Kq3OX7UakomyMBYMbHvJTJWNzDVbmFr345rfZhNmE7m4YjIa8tDK xC9peBlGek6Jcrn1zrUk0ZGyeLcLQLLn/qClDZu01loSvm75xV+jyr6m/OL9mJY/51 1wxxr+qwdWiTwydzXO4rV8hgvgqea39BlGxSmUDlQVcu3CIf4VWPveUPwdm0jNlHU8 c4yrHGfrfcbWhWY+aXlLx+qILyqelFr4X1aSa0IygbEE8FPjk1+PdpDp/B8sC6+xHw yd4D4xccgu3mC+4iXTc2Ak/X8Kh/rI3ANFjiq3RmiCS+Bw2ZQK+tmRa3solRgU435U 7SfU2RPtQnP2A== Date: Sat, 22 Jun 2024 15:39:40 +0200 From: Niklas Cassel To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kishon Vijay Abraham I , Arnd Bergmann , Damien Le Moal , Jon Lin , Shawn Lin , Simon Xue , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v5 00/13] PCI: dw-rockchip: Add endpoint mode support Message-ID: References: <20240607-rockchip-pcie-ep-v1-v5-0-0a042d6b0049@kernel.org> <20240621193937.GB3008482@rocinante> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240621193937.GB3008482@rocinante> On Sat, Jun 22, 2024 at 04:39:37AM +0900, Krzysztof Wilczyński wrote: > Hello, > > [...] > > If there is anything more I can do to get this picked up, please tell me. > > Looks good! As such... > > Applied to controller/rockchip, thank you! > > [01/04] PCI: dw-rockchip: Fix weird indentation > https://git.kernel.org/pci/pci/c/e7e8872191af > > [02/04] PCI: dw-rockchip: Add rockchip_pcie_get_ltssm() helper > https://git.kernel.org/pci/pci/c/cbb2d4ae3fdc > > [03/04] PCI: dw-rockchip: Add endpoint mode support > https://git.kernel.org/pci/pci/c/67fe449bcd85 > > [04/04] PCI: dw-rockchip: Refactor the driver to prepare for EP mode > https://git.kernel.org/pci/pci/c/ecdc98a3a912 Krzysztof, unfortunately, the controller/rockchip branch currently doesn't build: drivers/pci/controller/dwc/pcie-dw-rockchip.c: In function ‘rockchip_pcie_ep_sys_irq_thread’: drivers/pci/controller/dwc/pcie-dw-rockchip.c:407:17: error: implicit declaration of function ‘dw_pcie_ep_linkdown’; did you mean ‘dw_pcie_ep_linkup’? [-Wimplicit-function-declaration] 407 | dw_pcie_ep_linkdown(&pci->ep); | ^~~~~~~~~~~~~~~~~~~ | dw_pcie_ep_linkup Could you possibly include the commit: 3d2e425263e2 ("PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event") from the controller/dwc branch in the controller/rockchip as well, or rebase the controller/rockchip branch on top of the controller/dwc branch, or merge the controller/dwc branch to the controller/rockchip branch? Additionally, since you picked up Mani's series which removes dw_pcie_ep_init_notify() on the controller/dwc branch: 9eba2f70362f ("PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper") You will need to pick up this patch as well: https://lore.kernel.org/linux-pci/20240622132024.2927799-2-cassel@kernel.org/T/#u Otherwise there will be a build error when merging the controller/dwc and the controller/rockchip branch to for-next. The patch that I sent out can be picked up to the controller/rockchip right now (since the API that Mani is switching to already exists in Linus's tree). May I ask why all the branches for the different DWC glue drivers are not based on the controller/dwc branch? They are obviously going to be tightly related. Kind regards, Niklas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D46B9C27C53 for ; Sat, 22 Jun 2024 13:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MKAwIV6n0yGkUbxsejradpzAmnmHyRchp1XCXWM0GwQ=; b=1fKzfU5lqaLx92 UstOfoYdZ/Q+dLSpmSkuAYbsuRGk/SKTvaepgCLeZ9+2Ts7ZcIJ/7QegAJoJ6Q+afp5LBbmqOcu5v KbCM27h918FN+7Kqz5uDKKiAl7rdSUe5ZH/sbG021hUxvvh1lxQidGvWMTKCcacTFt2mxxmuaM4ap JOYkAUajmZXfO2S9Kkyx9Qu6kOe2ZTp47fZqKBkjjiEa3yXQqjKV/veMeyMNo61cgR9Qoc3NJweg7 zA2DukX41E7RYOiOHHvEPaYjL1LfiKalHPEkIoD+qR8WAi3ZzlzQeqlpx+r+8hljh9Qp+PCF7JV24 BHjqgMCD/r8nbvSf2OiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sL0y9-0000000CAg3-1LMb; Sat, 22 Jun 2024 13:39:53 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sL0y6-0000000CAf6-1M66 for linux-rockchip@lists.infradead.org; Sat, 22 Jun 2024 13:39:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 478A2CE069D; Sat, 22 Jun 2024 13:39:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 864CAC3277B; Sat, 22 Jun 2024 13:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719063587; bh=XoDceAdXs9z6NeEt0iuTL63LGCFyCmlS+FZp9Eo478A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRyrbmEZwPVx6Kq3OX7UakomyMBYMbHvJTJWNzDVbmFr345rfZhNmE7m4YjIa8tDK xC9peBlGek6Jcrn1zrUk0ZGyeLcLQLLn/qClDZu01loSvm75xV+jyr6m/OL9mJY/51 1wxxr+qwdWiTwydzXO4rV8hgvgqea39BlGxSmUDlQVcu3CIf4VWPveUPwdm0jNlHU8 c4yrHGfrfcbWhWY+aXlLx+qILyqelFr4X1aSa0IygbEE8FPjk1+PdpDp/B8sC6+xHw yd4D4xccgu3mC+4iXTc2Ak/X8Kh/rI3ANFjiq3RmiCS+Bw2ZQK+tmRa3solRgU435U 7SfU2RPtQnP2A== Date: Sat, 22 Jun 2024 15:39:40 +0200 From: Niklas Cassel To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kishon Vijay Abraham I , Arnd Bergmann , Damien Le Moal , Jon Lin , Shawn Lin , Simon Xue , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v5 00/13] PCI: dw-rockchip: Add endpoint mode support Message-ID: References: <20240607-rockchip-pcie-ep-v1-v5-0-0a042d6b0049@kernel.org> <20240621193937.GB3008482@rocinante> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240621193937.GB3008482@rocinante> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240622_063950_754946_9197363D X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMjIsIDIwMjQgYXQgMDQ6Mzk6MzdBTSArMDkwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgo+IEhlbGxvLAo+Cj4gWy4uLl0KPiA+IElmIHRoZXJlIGlzIGFueXRoaW5n IG1vcmUgSSBjYW4gZG8gdG8gZ2V0IHRoaXMgcGlja2VkIHVwLCBwbGVhc2UgdGVsbCBtZS4KPgo+ IExvb2tzIGdvb2QhIEFzIHN1Y2guLi4KPgo+IEFwcGxpZWQgdG8gY29udHJvbGxlci9yb2NrY2hp cCwgdGhhbmsgeW91IQo+Cj4gWzAxLzA0XSBQQ0k6IGR3LXJvY2tjaGlwOiBGaXggd2VpcmQgaW5k ZW50YXRpb24KPiAgICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcGNpL3BjaS9jL2U3ZTg4 NzIxOTFhZgo+Cj4gWzAyLzA0XSBQQ0k6IGR3LXJvY2tjaGlwOiBBZGQgcm9ja2NoaXBfcGNpZV9n ZXRfbHRzc20oKSBoZWxwZXIKPiAgICAgICAgIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcGNpL3Bj aS9jL2NiYjJkNGFlM2ZkYwo+Cj4gWzAzLzA0XSBQQ0k6IGR3LXJvY2tjaGlwOiBBZGQgZW5kcG9p bnQgbW9kZSBzdXBwb3J0Cj4gICAgICAgICBodHRwczovL2dpdC5rZXJuZWwub3JnL3BjaS9wY2kv Yy82N2ZlNDQ5YmNkODUKPgo+IFswNC8wNF0gUENJOiBkdy1yb2NrY2hpcDogUmVmYWN0b3IgdGhl IGRyaXZlciB0byBwcmVwYXJlIGZvciBFUCBtb2RlCj4gICAgICAgICBodHRwczovL2dpdC5rZXJu ZWwub3JnL3BjaS9wY2kvYy9lY2RjOThhM2E5MTIKCktyenlzenRvZiwKCnVuZm9ydHVuYXRlbHks IHRoZSBjb250cm9sbGVyL3JvY2tjaGlwIGJyYW5jaCBjdXJyZW50bHkgZG9lc24ndCBidWlsZDoK CmRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtZHctcm9ja2NoaXAuYzogSW4gZnVuY3Rp b24g4oCYcm9ja2NoaXBfcGNpZV9lcF9zeXNfaXJxX3RocmVhZOKAmToKZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpZS1kdy1yb2NrY2hpcC5jOjQwNzoxNzogZXJyb3I6IGltcGxpY2l0IGRl Y2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmGR3X3BjaWVfZXBfbGlua2Rvd27igJk7CglkaWQgeW91 IG1lYW4g4oCYZHdfcGNpZV9lcF9saW5rdXDigJk/IFstV2ltcGxpY2l0LWZ1bmN0aW9uLWRlY2xh cmF0aW9uXQogIDQwNyB8ICAgICAgICAgICAgICAgICBkd19wY2llX2VwX2xpbmtkb3duKCZwY2kt PmVwKTsKICAgICAgfCAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fgogICAgICB8 ICAgICAgICAgICAgICAgICBkd19wY2llX2VwX2xpbmt1cAoKCkNvdWxkIHlvdSBwb3NzaWJseSBp bmNsdWRlIHRoZSBjb21taXQ6CjNkMmU0MjUyNjNlMiAoIlBDSTogZHdjOiBlcDogQWRkIGEgZ2Vu ZXJpYyBkd19wY2llX2VwX2xpbmtkb3duKCkgQVBJIHRvIGhhbmRsZSBMaW5rIERvd24gZXZlbnQi KQpmcm9tIHRoZSBjb250cm9sbGVyL2R3YyBicmFuY2ggaW4gdGhlIGNvbnRyb2xsZXIvcm9ja2No aXAgYXMgd2VsbCwKb3IgcmViYXNlIHRoZSBjb250cm9sbGVyL3JvY2tjaGlwIGJyYW5jaCBvbiB0 b3Agb2YgdGhlIGNvbnRyb2xsZXIvZHdjIGJyYW5jaCwKb3IgbWVyZ2UgdGhlIGNvbnRyb2xsZXIv ZHdjIGJyYW5jaCB0byB0aGUgY29udHJvbGxlci9yb2NrY2hpcCBicmFuY2g/CgoKCkFkZGl0aW9u YWxseSwgc2luY2UgeW91IHBpY2tlZCB1cCBNYW5pJ3Mgc2VyaWVzIHdoaWNoIHJlbW92ZXMKZHdf cGNpZV9lcF9pbml0X25vdGlmeSgpIG9uIHRoZSBjb250cm9sbGVyL2R3YyBicmFuY2g6CjllYmEy ZjcwMzYyZiAoIlBDSTogZHdjOiBlcDogUmVtb3ZlIGR3X3BjaWVfZXBfaW5pdF9ub3RpZnkoKSB3 cmFwcGVyIikKCllvdSB3aWxsIG5lZWQgdG8gcGljayB1cCB0aGlzIHBhdGNoIGFzIHdlbGw6Cmh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXBjaS8yMDI0MDYyMjEzMjAyNC4yOTI3Nzk5LTIt Y2Fzc2VsQGtlcm5lbC5vcmcvVC8jdQpPdGhlcndpc2UgdGhlcmUgd2lsbCBiZSBhIGJ1aWxkIGVy cm9yIHdoZW4gbWVyZ2luZyB0aGUgY29udHJvbGxlci9kd2MKYW5kIHRoZSBjb250cm9sbGVyL3Jv Y2tjaGlwIGJyYW5jaCB0byBmb3ItbmV4dC4KVGhlIHBhdGNoIHRoYXQgSSBzZW50IG91dCBjYW4g YmUgcGlja2VkIHVwIHRvIHRoZSBjb250cm9sbGVyL3JvY2tjaGlwIHJpZ2h0Cm5vdyAoc2luY2Ug dGhlIEFQSSB0aGF0IE1hbmkgaXMgc3dpdGNoaW5nIHRvIGFscmVhZHkgZXhpc3RzIGluIExpbnVz J3MgdHJlZSkuCgoKCk1heSBJIGFzayB3aHkgYWxsIHRoZSBicmFuY2hlcyBmb3IgdGhlIGRpZmZl cmVudCBEV0MgZ2x1ZSBkcml2ZXJzIGFyZSBub3QKYmFzZWQgb24gdGhlIGNvbnRyb2xsZXIvZHdj IGJyYW5jaD8KVGhleSBhcmUgb2J2aW91c2x5IGdvaW5nIHRvIGJlIHRpZ2h0bHkgcmVsYXRlZC4K CgpLaW5kIHJlZ2FyZHMsCk5pa2xhcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlw QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1yb2NrY2hpcAo=