From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v2 0/9] drm/i915: Polish plane surface alignment handling
Date: Mon, 24 Jun 2024 17:33:04 +0300 [thread overview]
Message-ID: <ZnmDoHVktyz6xwUU@intel.com> (raw)
In-Reply-To: <ZnLDKM2I8WWrWwmO@intel.com>
On Wed, Jun 19, 2024 at 02:38:16PM +0300, Ville Syrjälä wrote:
> On Wed, Jun 12, 2024 at 11:47:03PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_surf_alignment() in particular has devolved into
> > a complete mess. Redesign the code so that we can handle
> > alignment restrictions in a nicer. Also adjust alignment
> > for TGL+ to actually match the hardware requirements.
> >
> > v2: Drop the per-plane vma stuff as it was borked
> > Don't temporarily remove the 2MiB DPT alignment for UV on TGL
> >
> > Ville Syrjälä (9):
> > drm: Rename drm_plane_check_pixel_format() to drm_plane_has_format()
> > drm: Export drm_plane_has_format()
>
> Maarten/Maxime/Thomas, can I get an ack for merging these via
> drm-intel please?
Series pushed to drm-intel-next with Thomas's irc ack.
Thanks for the reviews and acks.
>
> > drm/i915: Introduce the plane->min_alignment() vfunc
> > drm/i915: Introduce fb->min_alignment
> > drm/i915: Split cursor alignment to per-platform vfuncs
> > drm/i915: Split pre-skl platforms out from intel_surf_alignment()
> > drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c
> > drm/i915: Update plane alignment requirements for TGL+
> > drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff
> >
> > drivers/gpu/drm/drm_atomic.c | 7 +-
> > drivers/gpu/drm/drm_crtc.c | 6 +-
> > drivers/gpu/drm/drm_crtc_internal.h | 2 -
> > drivers/gpu/drm/drm_plane.c | 23 ++-
> > drivers/gpu/drm/i915/display/i9xx_plane.c | 75 ++++++++-
> > drivers/gpu/drm/i915/display/intel_cursor.c | 38 +++++
> > .../drm/i915/display/intel_display_types.h | 5 +
> > drivers/gpu/drm/i915/display/intel_fb.c | 151 ++++--------------
> > drivers/gpu/drm/i915/display/intel_fb.h | 3 -
> > drivers/gpu/drm/i915/display/intel_fb_pin.c | 39 +++--
> > drivers/gpu/drm/i915/display/intel_fb_pin.h | 3 +-
> > drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +-
> > drivers/gpu/drm/i915/display/intel_sprite.c | 26 +++
> > .../drm/i915/display/skl_universal_plane.c | 85 +++++++++-
> > drivers/gpu/drm/xe/display/xe_fb_pin.c | 3 +-
> > drivers/gpu/drm/xe/display/xe_plane_initial.c | 4 +-
>
> Lucas, can you give me an ack for the merging the xe
> changes via drm-intel?
>
> > include/drm/drm_plane.h | 2 +
> > 17 files changed, 309 insertions(+), 168 deletions(-)
> >
> > --
> > 2.44.2
>
> --
> Ville Syrjälä
> Intel
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-06-24 14:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 20:47 [PATCH v2 0/9] drm/i915: Polish plane surface alignment handling Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 1/9] drm: Rename drm_plane_check_pixel_format() to drm_plane_has_format() Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 2/9] drm: Export drm_plane_has_format() Ville Syrjala
2024-06-17 14:25 ` Daniel Vetter
2024-06-19 11:31 ` [PATCH v3 " Ville Syrjala
2024-06-19 11:34 ` Daniel Stone
2024-06-12 20:47 ` [PATCH v2 3/9] drm/i915: Introduce the plane->min_alignment() vfunc Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 4/9] drm/i915: Introduce fb->min_alignment Ville Syrjala
2024-06-13 10:33 ` Imre Deak
2024-06-12 20:47 ` [PATCH v2 5/9] drm/i915: Split cursor alignment to per-platform vfuncs Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 6/9] drm/i915: Split pre-skl platforms out from intel_surf_alignment() Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 7/9] drm/i915: Move intel_surf_alignment() into skl_univerals_plane.c Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 8/9] drm/i915: Update plane alignment requirements for TGL+ Ville Syrjala
2024-06-12 20:47 ` [PATCH v2 9/9] drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff Ville Syrjala
2024-06-13 8:52 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Polish plane surface alignment handling (rev2) Patchwork
2024-06-13 9:09 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-14 3:22 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-19 11:38 ` [PATCH v2 0/9] drm/i915: Polish plane surface alignment handling Ville Syrjälä
2024-06-19 16:53 ` Ville Syrjälä
2024-06-19 18:59 ` Rodrigo Vivi
2024-06-24 14:33 ` Ville Syrjälä [this message]
2024-06-19 16:48 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Polish plane surface alignment handling (rev3) Patchwork
2024-06-19 16:58 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-19 20:50 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnmDoHVktyz6xwUU@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.