From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 24 Jun 2024 08:32:18 -0700 Subject: [PATCH 00/26] KVM: vfio: Hide KVM internals from others In-Reply-To: <504fa0a7264d4762afda2f13c3525ce5@huawei.com> References: <20230916003118.2540661-1-seanjc@google.com> <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 20, 2024, Shameerali Kolothum Thodi wrote: > > This is a borderline RFC series to hide KVM's internals from the rest of > > the kernel, where "internals" means data structures, enums, #defines, > > APIs, etc. that are intended to be KVM-only, but are exposed everywhere > > due to kvm_host.h (and other headers) living in the global include paths. > > Hi Sean, > > Just thought of checking with you on this series. Do you have plans to revive this > series? Yep! > The reason I am asking is, on ARM64/KVM side we do have a requirement > to share the KVM VMID with SMMUV3. Please see the RFC I sent out earlier this > year[1]. The series basically provides a way for KVM to pin a VMID and also > associates an iommufd ctx with a struct kvm * to retrieve that VMID. > > As mentioned above, some of the patches in this series(especially 1-4 & 6) that > does the VFIO cleanups and dropping CONFIG_KVM_VFIO looks very straightforward > and useful. I am thinking of including those when I re-spin my RFC series, if > that?s ok. Please don't include them, as the patch they build towards (patch 5) is buggy[*], and I am fairly certain that at least some of the patches will change significantly. I expect to re-start working on the series in ~2 weeks, and am planning on actively pushing the series (i.e. not ignoring it for months on end). [*] https://lore.kernel.org/all/ZWp_q1w01NCZi8KX at google.com > Please let me know your thoughts. > > [1]. https://lore.kernel.org/linux-iommu/20240209115824.GA2922446 at myrica From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464A619B59D for ; Mon, 24 Jun 2024 15:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719243141; cv=none; b=EgMCVmXQSonA6DPBiaL9A0ktRS0N17LpQ9j3IcrMxkiQQ0nTZPc8KNTgyCCNOLS8crT7tbCoTQH1wSJN/DRDbko4fb/xSGR69ztBtupK5jBecj12z9kDFvEMvhwDgzD+RcV0fJuAzBt9WYa/7KyHRyxYXn1nRqKWsWMNTAqx2MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719243141; c=relaxed/simple; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ogl3zIZu4G8khwkYMZcjZfpORzx8DlsaizXnm+uXglf6q2pf0yFUOD2LDUDTtTWXuqqM84qvZpUBYcCURK7dZ0DV0s7G+WZlY+ij9gb2O8AUULjC4mU5JewMfl1HdgIuWCZb+inxFClPUcs+P/Am0BO77V8K8YMBGcS8vIkqgoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=v1eCKeAM; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="v1eCKeAM" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2c8066074b5so2847274a91.1 for ; Mon, 24 Jun 2024 08:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719243140; x=1719847940; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=v1eCKeAMNDuWsaJTzRGUpkLXeiHp+BIWMC8FE9rGM+7HsWwZ82VQzhL4UeQIvIMP/q sKf5OJo6oevA0gRiuZ52unFCyQnq6DNDB0xxYKP4eHWG3++fn3Y+IDc00HorKMQ3Cj4o PMwNizsxEcoTvJ7eVKWX+rZ24NJA/3VIHXOHq6us+a8xZFgBF6q0EaOh6SoTaPWWSG/v 1V3LCj+8VxMZUlKQkTw0VwbrTucZ3JO0RDI2tRePWLZ/py/hbt7/qyVxyyOkot+pcdeL 90ZQx0K9LQN9kv2hPF1wkymK7dBOFMq8HhxqqLuuzuuBiz16bfPIYuI9ME3K7mbrVEvV hm6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719243140; x=1719847940; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=RlYfjucPpmHz6Vy2QWtHgxFu4KUKXwpkQkFSTpWL1DMYVhXTy4dt5eAC+cISRkLA3p MeAbg6aRgEVlbtAu+mirydKHOZHNBpH/LoXRFe75RMQIgSH/oA8I/WVA0FTdqns2ydd7 s65g7qlt6CHKIuPbNDbQBK8F3SNBcYEeV88/+JX2zWtJchQYAb4EbJF6+L4v21jTY2ck 8iy9wl31NZXVGiDbepauQrycNwCZ2mS+0p9jLbqdF0HK7jnwb1ubhOWYauYvv6ihiQwd d6kVWtXHg8k2e9spJNSVIwlfcryhjQOo0fVy1wIlYYxHoAlJFBfwh/C//yWFw/vgIZRK DLSQ== X-Forwarded-Encrypted: i=1; AJvYcCUzgB43K2/isGX3EMVLStcuMMJesHRAMqLOe7ctRYsdP6w28ffJ4+oZwRVY3QD6T077nJ3NY1kOgmQOHKEGGixwMD+JtGCF X-Gm-Message-State: AOJu0YwAtOXE+iTtED44EhTpQoilOMpwlmmZC5LZGkQmVHs6tZqjw6f+ 8z1UVqCfG4YMhp9YmlGd458tJFnekQ5JRi9Wg2lOhHm6HK631zd66LLL6EjThUJ21Y/jRbVmfDq isA== X-Google-Smtp-Source: AGHT+IEtazAEW7Z9YwGGcKXL++Dckd0kAEwC6pBQKn1v/nxqOqzOdwWoLb56caKLmrQdFmUesETPkh89cIs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:2ecc:b0:2c6:d13f:3f9e with SMTP id 98e67ed59e1d1-2c8489b9ed7mr123696a91.1.1719243139430; Mon, 24 Jun 2024 08:32:19 -0700 (PDT) Date: Mon, 24 Jun 2024 08:32:18 -0700 In-Reply-To: <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230916003118.2540661-1-seanjc@google.com> <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Message-ID: Subject: Re: [PATCH 00/26] KVM: vfio: Hide KVM internals from others From: Sean Christopherson To: Shameerali Kolothum Thodi Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-mips@vger.kernel.org" , "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 20, 2024, Shameerali Kolothum Thodi wrote: > > This is a borderline RFC series to hide KVM's internals from the rest o= f > > the kernel, where "internals" means data structures, enums, #defines, > > APIs, etc. that are intended to be KVM-only, but are exposed everywhere > > due to kvm_host.h (and other headers) living in the global include path= s. > > Hi Sean, >=20 > Just thought of checking with you on this series. Do you have plans to re= vive this > series? Yep! > The reason I am asking is, on ARM64/KVM side we do have a requirement > to share the KVM VMID with SMMUV3. Please see the RFC I sent out earlier = this > year[1]. The series basically provides a way for KVM to pin a VMID and al= so > associates an iommufd ctx with a struct kvm * to retrieve that VMID.=20 >=20 > As mentioned above, some of the patches in this series(especially 1-4 & 6= ) that > does the VFIO cleanups and dropping CONFIG_KVM_VFIO looks very straightfo= rward > and useful. I am thinking of including those when I re-spin my RFC series= , if > that=E2=80=99s ok. Please don't include them, as the patch they build towards (patch 5) is bug= gy[*], and I am fairly certain that at least some of the patches will change signi= ficantly. I expect to re-start working on the series in ~2 weeks, and am planning on = actively pushing the series (i.e. not ignoring it for months on end). [*] https://lore.kernel.org/all/ZWp_q1w01NCZi8KX@google.com > Please let me know your thoughts. > > [1]. https://lore.kernel.org/linux-iommu/20240209115824.GA2922446@myrica= =20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5260C2D0D1 for ; Mon, 24 Jun 2024 15:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hQX2HpWR74XI3/kWntyXopA8mRGEmRvWqejPXRspObg=; b=jLKCcl5hMlTAkwJXOZGYl6q8D2 y/MoNNVxgndwTz3lW2DcZgmwxAoW3z8a1ewTqP/hpv0Peo9JJ5Trr6em0mCksCe8Q7Anr78eZPQPr UTJeZhHhmZoCF9GAXbIOOS7nKpgJVVGujJsGb8PLx19ToSi7NyrSvnsEGuziNsBGhPnNOcLrBXJla /xsQiNTYMI4H7dmYK9OuhnPoIWJru7yqm2wHfWfUYzIeJu4OOf7YI4bOgQO06XlnoLLuvOJjDRSNA D+GoMLbsqekUosMdVawsRzJN4rACh7FKcQqE8+aniIAt9AkBVqVdiOJD2CWUQ2ZrwwgGE7ZC0/CAy WwI4/JjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLlg8-0000000HKny-25Jr; Mon, 24 Jun 2024 15:32:24 +0000 Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLlg5-0000000HKmH-1S1a for linux-riscv@lists.infradead.org; Mon, 24 Jun 2024 15:32:23 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-2c7d2380cb8so3818682a91.0 for ; Mon, 24 Jun 2024 08:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719243140; x=1719847940; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=0/wo+ppheP2fkPy0zieksi98wEeRgNJ46QGG9IOpHuCI5kDhxi0tkpPj7dz4jDOGw2 9WdVOa8tVVSYgUWKguTYge9jld7rLKgWpwl7tSC9tWnP1vllS5prhtHKAkqDahpIDpyr wLYtRA0++nhWasifCmVpERTgdHhpPch8tL08aBqx43ARb3U0CFhp7KaPgagxhE5d7hfk /hcriaS0dBLEwYfZrCdLltZqEKn9chsS6M930wWEQHHaiEnHvekYs134yKjvH9mosLzM Y6XB8N6baIUxXaOXNaKi8vGu78e0oYoNt+E8WC0OtmQur6zLi8IRblyxtf+3f6BeRLED UifA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719243140; x=1719847940; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=olauum2hLUShkzqYlLgA3xW7VF5sL5UgO3tQ1kOkJN8KjBa0HdbhvyVSrmOpvq6HAm YKS8OHtv4K+josQ8b6Hy0P1Om6pdfzPsrzfv7iZHeU9vjNUsGhRlMLAxOkaMSHOZqwKy I7Eq0GAqKum99B3jk0IM28wHD/qEAiJYXGdoYqGV0cJlLq4IhE28Ex6v5+vrjRBgGrqx mwgFbPdIsetdjTl1w5m/hIdVoD7vutCWjlO6m18UdzJYu6K5rmmSJ6u+ssxa7Hbvz5eo 5EPWbOjTmHkVHZPjf+sXcJRjMbD7hTpA/fyGDtrNyHq5W5tDLS9PDv2wswn3AqNvkc6y rO6w== X-Forwarded-Encrypted: i=1; AJvYcCVWoS/qc3ifcuGxavhT7RCVSXYRE/uOjk8OVbETUBrVM8z2ngOWp1P2UJFDgu9EXc3oi0SLUL85L6n6RSwkIIkGFKcIaLzxqh/o/+nGcTPI X-Gm-Message-State: AOJu0Yy/+bUWsc0mAA6rQX1lI2FafOzN8RQoGn4tDDq8Ay6aD5fy3pkA Fgq3hGZMkFpanwylKFUu+BaHliz6ca9pKblHoYKPj/XI5cKQ/tZ2U4V5xYwLE2RrH2zbHO9JAOA /Eg== X-Google-Smtp-Source: AGHT+IEtazAEW7Z9YwGGcKXL++Dckd0kAEwC6pBQKn1v/nxqOqzOdwWoLb56caKLmrQdFmUesETPkh89cIs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:2ecc:b0:2c6:d13f:3f9e with SMTP id 98e67ed59e1d1-2c8489b9ed7mr123696a91.1.1719243139430; Mon, 24 Jun 2024 08:32:19 -0700 (PDT) Date: Mon, 24 Jun 2024 08:32:18 -0700 In-Reply-To: <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Mime-Version: 1.0 References: <20230916003118.2540661-1-seanjc@google.com> <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Message-ID: Subject: Re: [PATCH 00/26] KVM: vfio: Hide KVM internals from others From: Sean Christopherson To: Shameerali Kolothum Thodi Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-mips@vger.kernel.org" , "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "kvm-riscv@lists.infradead.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , Anish Ghulati , Venkatesh Srinivas , Andrew Thornton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_083221_411583_6D4E6D5B X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMjAsIDIwMjQsIFNoYW1lZXJhbGkgS29sb3RodW0gVGhvZGkgd3JvdGU6Cj4g PiBUaGlzIGlzIGEgYm9yZGVybGluZSBSRkMgc2VyaWVzIHRvIGhpZGUgS1ZNJ3MgaW50ZXJuYWxz IGZyb20gdGhlIHJlc3Qgb2YKPiA+IHRoZSBrZXJuZWwsIHdoZXJlICJpbnRlcm5hbHMiIG1lYW5z IGRhdGEgc3RydWN0dXJlcywgZW51bXMsICNkZWZpbmVzLAo+ID4gQVBJcywgZXRjLiB0aGF0IGFy ZSBpbnRlbmRlZCB0byBiZSBLVk0tb25seSwgYnV0IGFyZSBleHBvc2VkIGV2ZXJ5d2hlcmUKPiA+ IGR1ZSB0byBrdm1faG9zdC5oIChhbmQgb3RoZXIgaGVhZGVycykgbGl2aW5nIGluIHRoZSBnbG9i YWwgaW5jbHVkZSBwYXRocy4KPgo+IEhpIFNlYW4sCj4gCj4gSnVzdCB0aG91Z2h0IG9mIGNoZWNr aW5nIHdpdGggeW91IG9uIHRoaXMgc2VyaWVzLiBEbyB5b3UgaGF2ZSBwbGFucyB0byByZXZpdmUg dGhpcwo+IHNlcmllcz8KClllcCEKCj4gVGhlIHJlYXNvbiBJIGFtIGFza2luZyBpcywgb24gQVJN NjQvS1ZNIHNpZGUgd2UgZG8gaGF2ZSBhIHJlcXVpcmVtZW50Cj4gdG8gc2hhcmUgdGhlIEtWTSBW TUlEIHdpdGggU01NVVYzLiBQbGVhc2Ugc2VlIHRoZSBSRkMgSSBzZW50IG91dCBlYXJsaWVyIHRo aXMKPiB5ZWFyWzFdLiBUaGUgc2VyaWVzIGJhc2ljYWxseSBwcm92aWRlcyBhIHdheSBmb3IgS1ZN IHRvIHBpbiBhIFZNSUQgYW5kIGFsc28KPiBhc3NvY2lhdGVzIGFuIGlvbW11ZmQgY3R4IHdpdGgg YSBzdHJ1Y3Qga3ZtICogdG8gcmV0cmlldmUgdGhhdCBWTUlELiAKPiAKPiBBcyBtZW50aW9uZWQg YWJvdmUsIHNvbWUgb2YgdGhlIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMoZXNwZWNpYWxseSAxLTQg JiA2KSB0aGF0Cj4gZG9lcyB0aGUgVkZJTyBjbGVhbnVwcyBhbmQgZHJvcHBpbmcgQ09ORklHX0tW TV9WRklPIGxvb2tzIHZlcnkgc3RyYWlnaHRmb3J3YXJkCj4gYW5kIHVzZWZ1bC4gSSBhbSB0aGlu a2luZyBvZiBpbmNsdWRpbmcgdGhvc2Ugd2hlbiBJIHJlLXNwaW4gbXkgUkZDIHNlcmllcywgaWYK PiB0aGF04oCZcyBvay4KClBsZWFzZSBkb24ndCBpbmNsdWRlIHRoZW0sIGFzIHRoZSBwYXRjaCB0 aGV5IGJ1aWxkIHRvd2FyZHMgKHBhdGNoIDUpIGlzIGJ1Z2d5WypdLAphbmQgSSBhbSBmYWlybHkg Y2VydGFpbiB0aGF0IGF0IGxlYXN0IHNvbWUgb2YgdGhlIHBhdGNoZXMgd2lsbCBjaGFuZ2Ugc2ln bmlmaWNhbnRseS4KCkkgZXhwZWN0IHRvIHJlLXN0YXJ0IHdvcmtpbmcgb24gdGhlIHNlcmllcyBp biB+MiB3ZWVrcywgYW5kIGFtIHBsYW5uaW5nIG9uIGFjdGl2ZWx5CnB1c2hpbmcgdGhlIHNlcmll cyAoaS5lLiBub3QgaWdub3JpbmcgaXQgZm9yIG1vbnRocyBvbiBlbmQpLgoKWypdIGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2FsbC9aV3BfcTF3MDFOQ1ppOEtYQGdvb2dsZS5jb20KCj4gUGxlYXNl IGxldCBtZSBrbm93IHlvdXIgdGhvdWdodHMuCj4KPiBbMV0uIGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2xpbnV4LWlvbW11LzIwMjQwMjA5MTE1ODI0LkdBMjkyMjQ0NkBteXJpY2EgCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWls aW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECE72C2BD09 for ; Mon, 24 Jun 2024 15:33:07 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=BZDmtJp9; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W7Bmx3kPtz3dK9 for ; Tue, 25 Jun 2024 01:33:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=BZDmtJp9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::1049; helo=mail-pj1-x1049.google.com; envelope-from=3g5f5zgykdmy4qmzvos00sxq.o0yxuz6911o-pq7xu454.0bxmn4.03s@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W7Bm70QvDz3dH2 for ; Tue, 25 Jun 2024 01:32:21 +1000 (AEST) Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-2c8066074b5so2847267a91.1 for ; Mon, 24 Jun 2024 08:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719243140; x=1719847940; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=BZDmtJp9WZqlMith2ZS1v7BhPdDq89R+36lXS0Zil975Iz4FJmEF4RF8YZ6R8pQM8J sMP+9hRn/KKhaPvy0UY+ILIYJONQa2QMh0GNa8QVMT8Bci7pzykkAJP9AELwqFPJezF7 s7JPJyTYZg4nmoZsVh/hVCuws3i94bDD0j3BdgqS1B0sSgkF98GPit4hkqM/xTJlR43q 4+lMGOyGYV/aJ9mDMsir94pNKkj3bBaHL3yUxCZAjqqepypqOiD72PCdjMjI2AmhMTz4 wtuEQn9EcDrmj6+kEWsMczvLGtj7mHJ88Gwcl6cCtHf696kvF0GHWFUq1ovptTevYQrF Ne+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719243140; x=1719847940; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WawAVsLJ2wrVp06E1yLAnPzm2a05JueYQ9ExxNigc3k=; b=TUkyS6bJOyKP0U0FcjzmhyqM3OLwVTNsYh7Xh2qJrFaW/Uuic6/Pm2GRqGSwA/Zp0F rBjyo1aUC0geYZ0Gbtm5BNXQXVDYrKmU8APSDiQHgPlNf8vEDuoX7n6YBBLamkYyNF9K R5MwB80l1rNXBPR5SMkOoWpwJtPXqxC6HRv1hHujUMD6rfrsEl9gIELs2QGVABFdvZY1 Z9Ci8czoi8AOMOVkyyGPhMIv7jwopnaTz5yUPph5Y5lMjiYRpE1xdCqh2MSlDTs3vpZC zHQMamqHH3T3IxsobZWt3yUZXWAUs0QRNCxMMyFk8kW/Q2mPNc/OsNV2Y36txtFaLd7y up5g== X-Forwarded-Encrypted: i=1; AJvYcCXeWyyZR2dZfbTcPH8s7h9ystuLX0a1+aG7VbDeTDb+LqYinGQt+J5+Ptw10u0NqO1YgafgTPgB97yvzvIdNZfF2bXe7158y6caYTTJ1A== X-Gm-Message-State: AOJu0Yyq6GK2rL3cDI8cnzsoqnUnLiBSoG41oCifjXgu/I82no7MyvJZ f7irf3rBkyxT5NAB6C063E9nmhcEOF2WltkIkWxee9iyYDxfmpY4Q6j/WPIxlP0pxEvczLXOEtO Lpw== X-Google-Smtp-Source: AGHT+IEtazAEW7Z9YwGGcKXL++Dckd0kAEwC6pBQKn1v/nxqOqzOdwWoLb56caKLmrQdFmUesETPkh89cIs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:2ecc:b0:2c6:d13f:3f9e with SMTP id 98e67ed59e1d1-2c8489b9ed7mr123696a91.1.1719243139430; Mon, 24 Jun 2024 08:32:19 -0700 (PDT) Date: Mon, 24 Jun 2024 08:32:18 -0700 In-Reply-To: <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Mime-Version: 1.0 References: <20230916003118.2540661-1-seanjc@google.com> <504fa0a7264d4762afda2f13c3525ce5@huawei.com> Message-ID: Subject: Re: [PATCH 00/26] KVM: vfio: Hide KVM internals from others From: Sean Christopherson To: Shameerali Kolothum Thodi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "x86@kernel.org" , "kvm@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , Dave Hansen , "linux-kernel@vger.kernel.org" , Alexander Gordeev , Claudio Imbrenda , Will Deacon , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , Janosch Frank , Harald Freudenberger , Marc Zyngier , Huacai Chen , Halil Pasic , Andrew Thornton , Ingo Molnar , Christian Borntraeger , Jason Herne , Albert Ou , Vasily Gorbik , Venkatesh Srinivas , Heiko Carstens , Arnaldo Carvalho de Melo , Alex Williamson , Borislav Petkov , Andy Lutomirski , Paul Walmsley , "kvmarm@lists.linux.dev" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Tony Krowiak , Anish Ghulati , "linux-mips@vger.kernel.org" , Oliver Upton , "linux-perf-users@vger.kernel.org" , Palmer Dabbelt , "kvm-riscv@lists.infradead.org" , Anup Patel , Paolo Bonzini , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jun 20, 2024, Shameerali Kolothum Thodi wrote: > > This is a borderline RFC series to hide KVM's internals from the rest o= f > > the kernel, where "internals" means data structures, enums, #defines, > > APIs, etc. that are intended to be KVM-only, but are exposed everywhere > > due to kvm_host.h (and other headers) living in the global include path= s. > > Hi Sean, >=20 > Just thought of checking with you on this series. Do you have plans to re= vive this > series? Yep! > The reason I am asking is, on ARM64/KVM side we do have a requirement > to share the KVM VMID with SMMUV3. Please see the RFC I sent out earlier = this > year[1]. The series basically provides a way for KVM to pin a VMID and al= so > associates an iommufd ctx with a struct kvm * to retrieve that VMID.=20 >=20 > As mentioned above, some of the patches in this series(especially 1-4 & 6= ) that > does the VFIO cleanups and dropping CONFIG_KVM_VFIO looks very straightfo= rward > and useful. I am thinking of including those when I re-spin my RFC series= , if > that=E2=80=99s ok. Please don't include them, as the patch they build towards (patch 5) is bug= gy[*], and I am fairly certain that at least some of the patches will change signi= ficantly. I expect to re-start working on the series in ~2 weeks, and am planning on = actively pushing the series (i.e. not ignoring it for months on end). [*] https://lore.kernel.org/all/ZWp_q1w01NCZi8KX@google.com > Please let me know your thoughts. > > [1]. https://lore.kernel.org/linux-iommu/20240209115824.GA2922446@myrica= =20