All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrei Lalaev <andrey.lalaev@gmail.com>
Cc: robh@kernel.org, m.felsch@pengutronix.de,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrei Lalaev <andrei.lalaev@anton-paar.com>
Subject: Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error
Date: Tue, 25 Jun 2024 09:14:29 -0700	[thread overview]
Message-ID: <Znrs5QVAuSjH5sCT@google.com> (raw)
In-Reply-To: <20240617183018.916234-1-andrey.lalaev@gmail.com>

On Mon, Jun 17, 2024 at 08:30:18PM +0200, Andrei Lalaev wrote:
> From: Andrei Lalaev <andrei.lalaev@anton-paar.com>
> 
> If the device is missing, we get the following error:
> 
>   qt1050 3-0041: ID -1340767592 not supported
> 
> Let's handle this situation and print more informative error
> when reading of CHIP_ID fails:
> 
>   qt1050 3-0041: Failed to read chip ID: -6
> 
> Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@anton-paar.com>

Applied, thank you.

But how did we get into the situation with the chip being missing?
Incorrect DTB for the board?

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2024-06-25 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 18:30 [PATCH] Input: qt1050 - handle CHIP_ID reading error Andrei Lalaev
2024-06-25  8:32 ` Marco Felsch
2024-06-25 16:14 ` Dmitry Torokhov [this message]
2024-06-25 19:35   ` Andrei Lalaev
  -- strict thread matches above, loose matches on Subject: below --
2024-06-25 19:30 Andrei Lalaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Znrs5QVAuSjH5sCT@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=andrei.lalaev@anton-paar.com \
    --cc=andrey.lalaev@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.