Re: [PATCH V3 10/10] perf test: Check output of the probe ... --funcs command

[Namhyung Kim <namhyung@kernel.org>]

On Tue, Jun 25, 2024 at 01:40:57PM +0100, James Clark wrote:
> 
> 
> On 25/06/2024 00:30, Namhyung Kim wrote:
> > On Sat, Jun 01, 2024 at 06:29:46PM +0530, Chaitanya S Prakash wrote:
> >> From: Chaitanya S Prakash <chaitanyas.prakash@arm.com>
> >>
> >> Test "perf probe of function from different CU" only checks if the perf
> >> command has failed and doesn't test the --funcs output. In the issue
> >> reported in the previous commit, the garbage output of the --funcs
> >> command was being ignored by the test when it could have been caught.
> >>
> >> The script first makes use of --funcs option with the perf probe command
> >> to check if the function "foo" exists in the testfile before adding a
> >> probe to it in the next command. The output of probe...--funcs command
> >> is redirected to stdout, therefore, add '| grep "foo"' to validate the
> >> result.
> > 
> > Ok, I think this can be applied separately.
> > 
> 
> Yeah I think it can. There was a question from Arnaldo about this one on
> a previous version, but Chaitanya clarified about the stderr vs stdout
> thing:
> 
> https://lore.kernel.org/linux-perf-users/7d6330bd-5b0a-49d2-83bf-ac1ca11996d0@arm.com/#t

Thanks for the pointer.  I've also checked show_available_funcs() -
which is called for -F/--funcs option - uses the plain printf().

https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/probe-event.c?h=perf-tools-next#n3801

Thanks,
Namhyung