From: Jisheng Zhang <jszhang@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'dw_apb_ictl_handle_irq'
Date: Wed, 26 Jun 2024 19:40:48 +0800 [thread overview]
Message-ID: <Znv-QA4QM_JLZwo3@xhacker> (raw)
In-Reply-To: <87v81y6v6d.ffs@tglx>
On Mon, Jun 24, 2024 at 08:40:42PM +0200, Thomas Gleixner wrote:
> On Tue, Jun 25 2024 at 02:06, kernel test robot wrote:
> > Hi Jisheng,
> >
> > First bad commit (maybe != root cause):
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
> > head: f2605e1715dd28e8943b557453fed3a40421d3b5
> > commit: 7cc4f309c933ec5d64eea31066fe86bbf9e48819 [41/49] irqchip/dw-apb-ictl: Support building as module
> > config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240625/202406250214.WZEjWnnU-lkp@intel.com/config)
> > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240625/202406250214.WZEjWnnU-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202406250214.WZEjWnnU-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> >>> drivers/irqchip/irq-dw-apb-ictl.c:33:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'dw_apb_ictl_handle_irq'
> > 33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
> > | ^~~~~~~~~~~~~~~~~~~~~~
>
> That's because the drivers is now selectable via Kconfig, so
> allmodconfig sets it to M and builds it which does not work on a x86
> build unsurprisingly.
Yes, I didn't take care this.
>
> Jisheng, please send a delta fix ASAP. Otherwise I have to revert it.
I missed it. I will send a v2. Even if it's too late, it can be picked
up in next development window.
prev parent reply other threads:[~2024-06-26 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 18:06 [tip:irq/core 41/49] drivers/irqchip/irq-dw-apb-ictl.c:33:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'dw_apb_ictl_handle_irq' kernel test robot
2024-06-24 18:40 ` Thomas Gleixner
2024-06-26 11:40 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Znv-QA4QM_JLZwo3@xhacker \
--to=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.