All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jianbo Liu <jianbol@nvidia.com>,
	Eric Dumazet <edumazet@google.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 ipsec] xfrm: Fix unregister netdevice hang on hardware offload.
Date: Wed, 26 Jun 2024 13:30:40 +0200	[thread overview]
Message-ID: <Znv74OG152yuwMBM@gauss3.secunet.de> (raw)
In-Reply-To: <20240624102751.GE29266@unreal>

On Mon, Jun 24, 2024 at 01:27:51PM +0300, Leon Romanovsky wrote:
> On Thu, Jun 20, 2024 at 08:47:24AM +0200, Steffen Klassert wrote:
> > When offloading xfrm states to hardware, the offloading
> > device is attached to the skbs secpath. If a skb is free
> > is deferred, an unregister netdevice hangs because the
> > netdevice is still refcounted.
> > 
> > Fix this by removing the netdevice from the xfrm states
> > when the netdevice is unregistered. To find all xfrm states
> > that need to be cleared we add another list where skbs
> > linked to that are unlinked from the lists (deleted)
> > but not yet freed.
> > 
> > Changes in v2:
> > 
> > - Fix build with CONFIG_XFRM_OFFLOAD disabled.
> > - Fix two typos in the commit message.
> 
> Changelog should be after "---" trailer marker.

I've hand edited it out.

> > Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> > Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

Now applied to the ipsec tree.

      reply	other threads:[~2024-06-26 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  6:47 [PATCH v2 ipsec] xfrm: Fix unregister netdevice hang on hardware offload Steffen Klassert
2024-06-24 10:27 ` Leon Romanovsky
2024-06-26 11:30   ` Steffen Klassert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Znv74OG152yuwMBM@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=edumazet@google.com \
    --cc=jianbol@nvidia.com \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.