From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180811847; Wed, 26 Jun 2024 07:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719386335; cv=none; b=XxcW3P7YnuvYRSNZGDPk3YA79Z7mlHrK1BWGauJPvYQEYXecBHRjJ6CNYP4uT0JSK/T6kivZW2BgnNjC5+CXcwm5jm2LA0ePBn5KZp6upKpy5f+/yjdey2jhRNrFWHhmVqlaxIIHKfkSiGJcKv4Wy/YoubyHsuqjWMmjZJpJJYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719386335; c=relaxed/simple; bh=cauOnyM3mpccR9Az33iL6akTiJwxBz1ku8JnGIBQNmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jz0XKVuqkeNqVikM89Oke697nCqXrBdN+uXjt5VdhxcJsJOzgy7uqUmy57eCtCtzpfcVu73g8NGHqHGbFYxOlXAOQBZbjOoMZtMQGqyDIAzqlitZZXnUb4CabflWjrANdIQNneA5RIhqxD/SQWsltEZOIANdim5EjVpzFTQLtOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=WryU+a+W; arc=none smtp.client-ip=103.168.172.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="WryU+a+W" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 2CF1A13804AE; Wed, 26 Jun 2024 03:18:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 26 Jun 2024 03:18:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1719386333; x=1719472733; bh=ZsR3tgejZcL3NaXPKlRQyIwBUNWp BvYb1BlpFjaZRXQ=; b=WryU+a+WdSr3DYn2QqXQAiHG69v/E8ylE5fwCb3E3Dqo tMmxjxrzp/+VeQvz8iDmWBBCldMRdkuQFNuq8j/7uR/cZMSl52OoFg9W+pBNY/KA O5rdR7f/ynKERaiqZ0dRA+4J+fGW5uKoOqBM9jmoPZb2lyXqlqzlPx9z+Kxf39Th 2jlS8Id+cHJwTfAxCrX48u8ozZrSPxOe8wsXSu5cHZIIFKa+MQbH+iBI6FN8mDra KpzaK3MaqBMCsuBb1OOCWOBiW2YGCyP2g+/3LyitpaitqJY2qDfAfc5jgFyH4Kg+ h415sqqfkJGl4MVdoVWVom4pHsqpgbvVmEnp53sBCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtddugdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Jun 2024 03:18:52 -0400 (EDT) Date: Wed, 26 Jun 2024 10:18:46 +0300 From: Ido Schimmel To: Adrian Moreno Cc: netdev@vger.kernel.org, aconole@redhat.com, echaudro@redhat.com, horms@kernel.org, i.maximets@ovn.org, dev@openvswitch.org, Yotam Gigi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 03/10] net: psample: skip packet copy if no listeners Message-ID: References: <20240625205204.3199050-1-amorenoz@redhat.com> <20240625205204.3199050-4-amorenoz@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625205204.3199050-4-amorenoz@redhat.com> On Tue, Jun 25, 2024 at 10:51:46PM +0200, Adrian Moreno wrote: > If nobody is listening on the multicast group, generating the sample, > which involves copying packet data, seems completely unnecessary. > > Return fast in this case. > > Reviewed-by: Simon Horman > Signed-off-by: Adrian Moreno Reviewed-by: Ido Schimmel