From: Breno Leitao <leitao@debian.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Sunil Goutham <sgoutham@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
horms@kernel.org,
"moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER"
<linux-arm-kernel@lists.infradead.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: thunderx: Unembed netdev structure
Date: Wed, 26 Jun 2024 08:12:51 -0700 [thread overview]
Message-ID: <Znwv8y03Ftzu0LP8@gmail.com> (raw)
In-Reply-To: <20240625175434.53ccea3a@kernel.org>
On Tue, Jun 25, 2024 at 05:54:34PM -0700, Jakub Kicinski wrote:
> On Mon, 24 Jun 2024 03:29:18 -0700 Breno Leitao wrote:
> > static void bgx_lmac_handler(struct net_device *netdev)
> > {
> > - struct lmac *lmac = container_of(netdev, struct lmac, netdev);
> > + struct lmac *lmac = netdev_priv(netdev);
>
> I think you are storing a pointer to lmac, so:
>
> struct lmac **priv = netdev_priv(netdev);
> struct lmac *lmac = *priv;
Good catch. you are absolutely correct. I will update.
prev parent reply other threads:[~2024-06-26 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 10:29 [PATCH net-next] net: thunderx: Unembed netdev structure Breno Leitao
2024-06-26 0:54 ` Jakub Kicinski
2024-06-26 15:12 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Znwv8y03Ftzu0LP8@gmail.com \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.