All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Abel Vesa <abel.vesa@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: enable GICv3 ITS for PCIe
Date: Thu, 11 Jul 2024 11:58:08 +0200	[thread overview]
Message-ID: <Zo-ssBBDbHRLtAwG@hovoldconsulting.com> (raw)
In-Reply-To: <f7e74a6f-0548-4caa-a8fc-8180c619c9aa@linaro.org>

On Thu, Jul 11, 2024 at 11:54:15AM +0200, Konrad Dybcio wrote:
> On 11.07.2024 11:02 AM, Johan Hovold wrote:
> > The DWC PCIe controller can be used with its internal MSI controller or
> > with an external one such as the GICv3 Interrupt Translation Service
> > (ITS).
> > 
> > Add the msi-map properties needed to use the GIC ITS. This will also
> > make Linux switch to the ITS implementation, which allows for assigning
> > affinity to individual MSIs.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> 
> X1E CRD throws tons of correctable errors with this on PCIe6a:
> 
> [    9.358915] pcieport 0007:00:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID)
> [    9.358916] pcieport 0007:00:00.0:   device [17cb:0111] error status/mask=00000001/0000e000
> [    9.358917] pcieport 0007:00:00.0:    [ 0] RxErr                 
> [    9.358921] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:00:00.0
> [    9.358952] pcieport 0007:00:00.0: AER: found no error details for 0007:00:00.0
> [    9.358953] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:00:00.0
> [    9.359003] pcieport 0007:00:00.0: AER: found no error details for 0007:00:00.0
> [    9.359004] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:01:00.0
> [    9.359008] pcieport 0007:00:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Transmitter ID)
> [    9.359009] pcieport 0007:00:00.0:   device [17cb:0111] error status/mask=00001001/0000e000
> [    9.359010] pcieport 0007:00:00.0:    [ 0] RxErr                 
> [    9.359011] pcieport 0007:00:00.0:    [12] Timeout  

What branch are you using? Abel reported seeing this with his branch
which has a few work-in-progress patches that try to enable 4-lane PCIe.

There are no errors with my wip branch based on rc7, and I have the same
drive as Abel.

Also note that the errors happen also without this patch applied, they
are just being reported now.

Johan

  reply	other threads:[~2024-07-11  9:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11  9:02 [PATCH] arm64: dts: qcom: x1e80100: enable GICv3 ITS for PCIe Johan Hovold
2024-07-11  9:54 ` Konrad Dybcio
2024-07-11  9:58   ` Johan Hovold [this message]
2024-07-11 10:00     ` Konrad Dybcio
2024-07-11 10:04       ` Johan Hovold
2024-07-11 15:01     ` Johan Hovold
2024-07-11 16:19       ` Manivannan Sadhasivam
2024-07-11 16:41         ` Manivannan Sadhasivam
2024-07-11 16:59           ` Johan Hovold
2024-07-12  8:20             ` Johan Hovold
2024-07-12 13:31               ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zo-ssBBDbHRLtAwG@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.