All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, thaller@redhat.com,
	jami.maenpaa@wapice.com
Subject: Re: [PATCH nft 1/2] parser_json: use stdin buffer if available
Date: Wed, 10 Jul 2024 17:52:21 +0200	[thread overview]
Message-ID: <Zo6uNc9oxoqMTwmU@orbyte.nwl.cc> (raw)
In-Reply-To: <20240710152004.11526-1-pablo@netfilter.org>

On Wed, Jul 10, 2024 at 05:20:03PM +0200, Pablo Neira Ayuso wrote:
> Since 5c2b2b0a2ba7 ("src: error reporting with -f and read from stdin")
> stdin is stored in a buffer, update json support to use it instead of
> reading from /dev/stdin.
> 
> Some systems do not provide /dev/stdin symlink to /proc/self/fd/0
> according to reporter (that mentions Yocto Linux as example).
> 
> Fixes: 935f82e7dd49 ("Support 'nft -f -' to read from stdin")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> v2: remove check for nft_output_json() in nft_run_cmd_from_filename()
>     as suggested by Phil Sutter, so JSON support does not really use
>     /dev/stdin.

Series:
Acked-by: Phil Sutter <phil@nwl.cc>

Thanks, Phil

  parent reply	other threads:[~2024-07-10 15:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 15:20 [PATCH nft 1/2] parser_json: use stdin buffer if available Pablo Neira Ayuso
2024-07-10 15:20 ` [PATCH nft 2/2] libnftables: skip useable checks for /dev/stdin Pablo Neira Ayuso
2024-07-10 15:52 ` Phil Sutter [this message]
2024-07-10 15:54   ` [PATCH nft 1/2] parser_json: use stdin buffer if available Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2024-07-09 14:59 Pablo Neira Ayuso
2024-07-10 13:53 ` Phil Sutter
2024-07-10 14:01   ` Phil Sutter
2024-07-10 14:04     ` Pablo Neira Ayuso
2024-07-10 15:15       ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zo6uNc9oxoqMTwmU@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=jami.maenpaa@wapice.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=thaller@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.