All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: linux@treblig.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-parport@lists.infradead.org
Subject: Re: [PATCH 2/3] parport: Remove attach function pointer
Date: Sun, 30 Jun 2024 22:01:50 +0100	[thread overview]
Message-ID: <ZoHHvuGQBFz0rg4m@debian> (raw)
In-Reply-To: <20240502154823.67235-3-linux@treblig.org>

On Thu, May 02, 2024 at 04:48:22PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> The attach function pointers haven't actually been called since:
>   'commit 3275158fa52a ("parport: remove use of devmodel")'
> topped adding entries to the drivers list.
> 
> If you're converting a driver, look at the 'match_port' function
> pointer instead.
> 
> (There are lots of comment references to 'attach' all over, but they
> probably need some deeper understanding to check the semantics
> to see if they can be replaced by match_port).
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

-- 
Regards
Sudip

  reply	other threads:[~2024-06-30 21:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 15:48 [PATCH 0/3] parport: Cleanup some pre-devmodel code linux
2024-05-02 15:48 ` [PATCH 1/3] parport: Remove 'drivers' list linux
2024-06-30 21:00   ` Sudip Mukherjee (Codethink)
2024-06-30 22:46     ` Dr. David Alan Gilbert
2024-05-02 15:48 ` [PATCH 2/3] parport: Remove attach function pointer linux
2024-06-30 21:01   ` Sudip Mukherjee [this message]
2024-05-02 15:48 ` [PATCH 3/3] parport: Remove parport_driver.devmodel linux
2024-06-30 21:03   ` Sudip Mukherjee
2024-05-16 10:46 ` [PATCH 0/3] parport: Cleanup some pre-devmodel code Dr. David Alan Gilbert
2024-06-03 17:39   ` Dr. David Alan Gilbert
2024-06-26 15:41     ` Dr. David Alan Gilbert
2024-06-27  8:51       ` Sudip Mukherjee
2024-06-27 11:34         ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoHHvuGQBFz0rg4m@debian \
    --to=sudipm.mukherjee@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=linux@treblig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.