All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Ayush Mishra <ayush.m55@samsung.com>
Cc: qemu-devel@nongnu.org, its@irrelevant.dk, foss@defmacro.it
Subject: Re: [PATCH] hw/nvme: actually implement abort
Date: Tue, 2 Jul 2024 09:24:59 -0600	[thread overview]
Message-ID: <ZoQby9WzEesIhuLz@kbusch-mbp> (raw)
In-Reply-To: <20240702080232.848849-1-ayush.m55@samsung.com>

On Tue, Jul 02, 2024 at 01:32:32PM +0530, Ayush Mishra wrote:
> Abort was not implemented previously, but we can implement it for AERs and asynchrnously for I/O.

Not implemented for a reason. The target has no idea if the CID the
host requested to be aborted is from the same context that the target
has. Target may have previoulsy completed it, and the host re-issued a
new command after the abort, and due to the queueing could have been
observed in a different order, and now you aborted the wrong command.


  reply	other threads:[~2024-07-02 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240702133144epcas5p22b982613bfbfce0e7ad0c74fd72a7956@epcas5p2.samsung.com>
2024-07-02  8:02 ` [PATCH] hw/nvme: actually implement abort Ayush Mishra
2024-07-02 15:24   ` Keith Busch [this message]
2024-07-02 18:55     ` Klaus Jensen
2024-07-10  9:09       ` Klaus Jensen
2024-07-11 15:01         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoQby9WzEesIhuLz@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=ayush.m55@samsung.com \
    --cc=foss@defmacro.it \
    --cc=its@irrelevant.dk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.