Re: [PATCH v2 2/2] Add a test case for perf script -F +metric

[Namhyung Kim <namhyung@kernel.org>]

On Thu, Jun 27, 2024 at 05:04:55PM -0700, Andi Kleen wrote:
> Just a simple test
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> --
> 
> v2: Avoid bashisms. Use noploop
> ---
>  tools/perf/tests/shell/script.sh | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/script.sh
> index c1a603653662..de4b1dce55ad 100755
> --- a/tools/perf/tests/shell/script.sh
> +++ b/tools/perf/tests/shell/script.sh
> @@ -7,6 +7,7 @@ set -e
>  temp_dir=$(mktemp -d /tmp/perf-test-script.XXXXXXXXXX)
>  
>  perfdatafile="${temp_dir}/perf.data"
> +scriptoutput="${temp_dir}/script"
>  db_test="${temp_dir}/db_test.py"
>  
>  err=0
> @@ -88,8 +89,21 @@ test_parallel_perf()
>  	echo "parallel-perf test [Success]"
>  }
>  
> +test_metric()
> +{
> +	echo "script metric test"
> +	if ! perf list | grep -q cycles ; then return ; fi
> +	if ! perf list | grep -q instructions ; then return ; fi
> +	perf record -e '{cycles,instructions}' -o "${perfdatafile}" perf test -w noploop
> +	perf script -i "${perfdatafile}" -F +metric  > $scriptoutput
> +	test `grep -c metric $scriptoutput` -gt 5

The shellcheck (now part of build process) doesn't like this.

  In tests/shell/script.sh line 99:
  	test `grep -c metric $scriptoutput` -gt 5
               ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
  
  For more information:
    https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  make[4]: *** [tests/Build:91: tests/shell/script.sh.shellcheck_log] Error 1
  make[3]: *** [linux/tools/build/Makefile.build:158: tests] Error 2
  make[2]: *** [Makefile.perf:750: perf-test-in.o] Error 2
  make[2]: *** Waiting for unfinished jobs....

Thanks,
Namhyung


> +	grep metric $scriptoutput | head
> +	echo "script metric test [Success]"
> +}
> +
>  test_db
>  test_parallel_perf
> +test_metric
>  
>  cleanup
>  
> -- 
> 2.45.2
>