From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
alexjlzheng@gmail.com, chandan.babu@oracle.com,
djwong@kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, alexjlzheng@tencent.com
Subject: Re: [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log_vec and free it early
Date: Tue, 2 Jul 2024 22:14:37 -0700 [thread overview]
Message-ID: <ZoTePWuRKxHXofGF@infradead.org> (raw)
In-Reply-To: <ZoSQ5BAhpwoYN4Dz@dread.disaster.area>
On Wed, Jul 03, 2024 at 09:44:36AM +1000, Dave Chinner wrote:
> Ah, ok, my bad. I missed that because the xfs_log_iovec is not the
> data buffer - it is specifically just the iovec array that indexes
> the data buffer. Everything in the commit message references the
> xfs_log_iovec, and makes no mention of the actual logged metadata
> that is being stored, and I didn't catch that the submitter was
> using xfs_log_iovec to mean something different to what I understand
> it to be from looking at the code. That's why I take the time to
> explain my reasoning - so that people aren't in any doubt about how
> I interpretted the changes and can easily point out where I've gone
> wrong. :)
And throw in the xfs_log_vec vs xfs_log_iovec naming that keeps
confusing me after all these years..
prev parent reply other threads:[~2024-07-03 5:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 4:49 [PATCH v3 0/2] Separate xfs_log_vec/iovec to save memory alexjlzheng
2024-06-26 4:49 ` [PATCH v3 1/2] xfs: add xfs_log_vec_cache for separate xfs_log_vec/xfs_log_iovec alexjlzheng
2024-06-26 4:49 ` [PATCH v3 2/2] xfs: make xfs_log_iovec independent from xfs_log_vec and free it early alexjlzheng
2024-07-01 0:51 ` Dave Chinner
2024-07-01 4:49 ` Christoph Hellwig
2024-07-02 23:44 ` Dave Chinner
2024-07-03 5:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoTePWuRKxHXofGF@infradead.org \
--to=hch@infradead.org \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.