All of lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Gaurav Jain <gaurav.jain@nxp.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	Horia Geanta <horia.geanta@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"horms@kernel.org" <horms@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] [PATCH net-next v3 4/4] crypto: caam: Unembed net_dev structure in dpaa2
Date: Wed, 3 Jul 2024 04:26:38 -0700	[thread overview]
Message-ID: <ZoU1bh79jugMaRty@gmail.com> (raw)
In-Reply-To: <AM0PR04MB600485850F153B6792CA8C0DE7DD2@AM0PR04MB6004.eurprd04.prod.outlook.com>

Hello Gaurav,

On Wed, Jul 03, 2024 at 05:45:23AM +0000, Gaurav Jain wrote:

> > @@ -5096,15 +5109,23 @@ static int __cold dpaa2_dpseci_setup(struct
> > fsl_mc_device *ls_dev)
> >                         priv->rx_queue_attr[j].fqid,
> >                         priv->tx_queue_attr[j].fqid);
> >
> > -               ppriv->net_dev.dev = *dev;
> > -               INIT_LIST_HEAD(&ppriv->net_dev.napi_list);

> napi_list is not needed anymore? There is no mention in commit.

Good question. This allocation is now done in the alloc_netdev_dummy()
path. This is the code path:

alloc_netdev_dummy()->alloc_netdev()->alloc_netdev_mqs() which calls:

	INIT_LIST_HEAD(&dev->napi_list);

So, napi_list is initialized when the net_device interface is allocated.

  reply	other threads:[~2024-07-03 11:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 18:55 [PATCH net-next v3 0/3] crypto: caam: Unembed net_dev Breno Leitao
2024-07-02 18:55 ` [PATCH net-next v3 1/4] crypto: caam: Avoid unused imx8m_machine_match variable Breno Leitao
2024-07-05 10:11   ` Horia Geanta
2024-07-08 11:29     ` Breno Leitao
2024-07-09 10:44       ` Horia Geanta
2024-07-02 18:55 ` [PATCH net-next v3 2/4] crypto: caam: Make CRYPTO_DEV_FSL_CAAM dependent of COMPILE_TEST Breno Leitao
2024-07-02 18:55 ` [PATCH net-next v3 3/4] crypto: caam: Unembed net_dev structure from qi Breno Leitao
2024-07-04  2:45   ` Jakub Kicinski
2024-07-04 16:15     ` Breno Leitao
2024-07-04 17:18       ` Jakub Kicinski
2024-07-02 18:55 ` [PATCH net-next v3 4/4] crypto: caam: Unembed net_dev structure in dpaa2 Breno Leitao
2024-07-03  5:45   ` [EXT] " Gaurav Jain
2024-07-03 11:26     ` Breno Leitao [this message]
2024-07-04 18:00 ` [PATCH net-next v3 0/3] crypto: caam: Unembed net_dev patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoU1bh79jugMaRty@gmail.com \
    --to=leitao@debian.org \
    --cc=davem@davemloft.net \
    --cc=gaurav.jain@nxp.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pankaj.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.