From: Michal Kubiak <michal.kubiak@intel.com>
To: <edward.cree@amd.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, Edward Cree <ecree.xilinx@gmail.com>,
<netdev@vger.kernel.org>, <danieller@nvidia.com>,
<andrew@lunn.ch>
Subject: Re: [PATCH net-next] ethtool: move firmware flashing flag to struct ethtool_netdev_state
Date: Wed, 3 Jul 2024 16:30:16 +0200 [thread overview]
Message-ID: <ZoVgeHbWG7N5yj9s@localhost.localdomain> (raw)
In-Reply-To: <20240703121849.652893-1-edward.cree@amd.com>
On Wed, Jul 03, 2024 at 01:18:49PM +0100, edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> Commit 31e0aa99dc02 ("ethtool: Veto some operations during firmware flashing process")
> added a flag module_fw_flash_in_progress to struct net_device. As
Nitpick: unnecessary space
> this is ethtool related state, move it to the recently created
> struct ethtool_netdev_state, accessed via the 'ethtool' member of
> struct net_device.
Nitpick: wrong indentation in the commit message
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
> ---
> Build tested only.
The code changes look OK. Just the commit message formatting needs to be
polished a little bit.
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2024-07-03 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:18 [PATCH net-next] ethtool: move firmware flashing flag to struct ethtool_netdev_state edward.cree
2024-07-03 14:30 ` Michal Kubiak [this message]
2024-07-03 17:29 ` Ido Schimmel
2024-07-05 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoVgeHbWG7N5yj9s@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.