From: Matthew Wilcox <willy@infradead.org>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: muchun.song@linux.dev, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hugetlbfs: support tracepoint
Date: Thu, 4 Jul 2024 04:37:30 +0100 [thread overview]
Message-ID: <ZoYY-sfj5jvs8UpQ@casper.infradead.org> (raw)
In-Reply-To: <20240704030704.2289667-2-lihongbo22@huawei.com>
On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote:
> + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o",
> + MAJOR(__entry->dev), MINOR(__entry->dev),
> + (unsigned long) __entry->ino,
> + (unsigned long) __entry->dir, __entry->mode)
erofs and f2fs are the only two places that print devices like this.
"dev=%d:%d inode=%lx"
Why do we need dir and mode?
Actually, why do we need a tracepoint on alloc_inode at all? What
does it help us debug, and why does no other filesystem need an
alloc_inode tracepoint?
next prev parent reply other threads:[~2024-07-04 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 3:07 [PATCH v2 0/2] Introduce tracepoint for hugetlbfs Hongbo Li
2024-07-04 3:07 ` [PATCH v2 1/2] hugetlbfs: support tracepoint Hongbo Li
2024-07-04 3:37 ` Matthew Wilcox [this message]
2024-07-04 6:40 ` Hongbo Li
2024-07-04 12:56 ` Dave Chinner
2024-07-04 14:13 ` Steven Rostedt
2024-07-04 23:34 ` Dave Chinner
2024-07-05 6:24 ` Hongbo Li
2024-07-04 3:07 ` [PATCH v2 2/2] hugetlbfs: use tracepoints in hugetlbfs functions Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoYY-sfj5jvs8UpQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=lihongbo22@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=muchun.song@linux.dev \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.