From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 504BEC3271E for ; Mon, 8 Jul 2024 04:27:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQfxS-0000vL-Hl; Mon, 08 Jul 2024 00:26:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQfxP-0000th-UP for qemu-riscv@nongnu.org; Mon, 08 Jul 2024 00:26:32 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQfxO-0001gC-4T for qemu-riscv@nongnu.org; Mon, 08 Jul 2024 00:26:31 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-7035b2947a4so1381994a34.3 for ; Sun, 07 Jul 2024 21:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1720412788; x=1721017588; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JUUBxMzRjQBsfjECj+DhRcfMU2jw9tTIrKCKiq0P4dE=; b=JH9Yj8rafKtDrnY/TDFehtxv8ftNFzhVNVM+f6dqlsL8b49LA20Wwa+iKLe707WK7r uJ8Hr4iT6/TxWNO8Ir/sWbskTwL/SdGO5xZmVryEIDVZtNE6wQc+PPMDXCAdn987phgX WeR+1XGrXTd6Z9i2/ulcEURDSMwX3abAP+53r1Bi0JZ0UPwMmupzt4/RTxwKOCLLbvpO dQt99qrA3OUR7LWr2l+xJy6goBD17xgc0NfAipMCIadA4XZae0l+qNN46au1LayiVXsL l3mo8dYoMhmo+a3oSY/VGZ9RGgCJAxpv5OEbfvl0XPcpoQ1LEBeUJj26bYzgHRtni1Xt 65mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720412788; x=1721017588; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JUUBxMzRjQBsfjECj+DhRcfMU2jw9tTIrKCKiq0P4dE=; b=USYev3sEc2usjjFh9K3R9FVrAlhhseprqANAbi+s8/y2Z4BES2SgdAjT28aeK5LJla mJvpIa6hqkCalyq/loFEu8/IqHdiX5k6qqZz0D+A2TCeuhSOt6/Es8wTNqR7YeOscaoP BpFn3P6mntePcpNvBp7D4T79ot6+vuf6mH0rHt4MVSmuNWJuabv4/uf3SkmFobviG6gx w82mRS606/9zFuFMUFRFe+T6a6BxWIYHBfPSoYJeBeyLDZwWiifNJoWNThnOfd1P+TIi sy+XQg1/eYMWzMDLyQKOcFDqVuKrcxYg5LZNQIZ3uXg1BAxPKJjbUOBH2v5NP7/UJMbU odlg== X-Forwarded-Encrypted: i=1; AJvYcCUtBuXgGFoS5PDRYQFtu62ZuMMAMPZd+wtZvLszqD6aa1eA9fYBKuryLJAT0q3zxBYu/2mcdrOQg0UDMZgygDTDftA0GhM= X-Gm-Message-State: AOJu0Yy0al6Hn1XB1geY365EnAs757f2sQJ0OMYLIaidfQtOg3fLEGGs By37dN8JCEShP70bb1Rdk7YysDDPzRu5P9Kg/GMJEnWZBtswejWNnxuGbObmknI= X-Google-Smtp-Source: AGHT+IGiJNq+uhlgEqH1ReBOwLU634s9ssjfomUCVH0jEmpJfJu9ymumJHhwC1SQGO7en7+nxwazEw== X-Received: by 2002:a9d:6d19:0:b0:703:64d4:8e0f with SMTP id 46e09a7af769-70364d48fc1mr4812669a34.6.1720412788521; Sun, 07 Jul 2024 21:26:28 -0700 (PDT) Received: from sunil-laptop ([106.51.187.237]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-701f7b35531sm3653472a34.65.2024.07.07.21.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jul 2024 21:26:27 -0700 (PDT) Date: Mon, 8 Jul 2024 09:56:14 +0530 From: Sunil V L To: Alistair Francis Cc: Jonathan Cameron , "Michael S. Tsirkin" , Igor Mammedov , qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Ani Sinha , Laurent Vivier , Gerd Hoffmann , Sia Jee Heng , Daniel Henrique Barboza , Palmer Dabbelt , Bin Meng , Weiwei Li , Liu Zhiwei , Alistair Francis Subject: Re: [PATCH v4 16/16] tests/qtest/bios-tables-test: Add expected ACPI data files for RISC-V Message-ID: References: <20240625150839.1358279-1-sunilvl@ventanamicro.com> <20240625150839.1358279-17-sunilvl@ventanamicro.com> <20240627141803.42cd46c1@imammedo.users.ipa.redhat.com> <20240701170330-mutt-send-email-mst@kernel.org> <20240702150236.000042eb@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::32b; envelope-from=sunilvl@ventanamicro.com; helo=mail-ot1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Mon, Jul 08, 2024 at 01:16:49PM +1000, Alistair Francis wrote: > On Thu, Jul 4, 2024 at 12:57 AM Sunil V L wrote: > > > > On Wed, Jul 03, 2024 at 03:53:08PM +0530, Sunil V L wrote: > > > On Tue, Jul 02, 2024 at 03:02:36PM +0100, Jonathan Cameron wrote: > > > > On Mon, 1 Jul 2024 17:03:43 -0400 > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > On Thu, Jun 27, 2024 at 02:18:03PM +0200, Igor Mammedov wrote: > > > > > > On Tue, 25 Jun 2024 20:38:39 +0530 > > > > > > Sunil V L wrote: > > > > > > > > > > > > > As per the step 5 in the process documented in bios-tables-test.c, > > > > > > > generate the expected ACPI AML data files for RISC-V using the > > > > > > > rebuild-expected-aml.sh script and update the > > > > > > > bios-tables-test-allowed-diff.h. > > > > > > > > > > > > > > These are all new files being added for the first time. Hence, iASL diff > > > > > > > output is not added. > > > > > > > > > > > > > > Signed-off-by: Sunil V L > > > > > > > Acked-by: Alistair Francis > > > > > > > Acked-by: Igor Mammedov > > > > > > > > > > > > Michael, > > > > > > can it go via risc-v tree or > > > > > > do you plan to merge it via your tree? > > > > > > > > > > given patch 1 is merged, I took the rest. > > > > > > > > Looks like your CI runs are catching this as well but > > > > RHCT here is failing. I rebased the GI/GP set on top of this > > > > and ignored that failure by skipping riscv64 tests. > > > > > > > > Jonathan > > > > > > > Hi Jonathan, Michael, > > > > > > Looks like a recent RISC-V PR updated the rva22s64 ISA string affecting > > > the RHCT I had in my series. I see that Michael dropped those 3 RISC-V > > > patches from the PR. So, let me update the expected RHCT AML file in a > > > new series. I will also include Igor's feedback to remove fallback path > > > in that series. > > > > > Hi Alistair, > > > > This issue is because, below 3 extensions are present in the ISA string > > for rva22s64 profile cpu after recent RISC-V PR. > > > > zmmul_zaamo_zalrsc > > zmmul (multiply) is implied by M (multiply and divide). The other two > are similar. > > > > > However, IIUC, they are not mentioned in the RVA22S64 profile spec. Because of > > this change, my AML files are having a difference and failing CI. The > > question is, is this correct behavior? If so, I can update the AML files > > and resubmit the patches. Let me know. > > This does feel correct. Is software only needed zmmul for multiplying > then reporting zmmul when we support M feels like the right thing to > do. > > I can't find a spec that says either way though. So unless anyone else > knows of one I think this current approach is correct > Thanks a lot, Alistair. I had a discussion with Daniel as well and we concluded the same. I will update the AML files. Thanks, Sunil