From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A0C14AD10 for ; Mon, 8 Jul 2024 19:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720466804; cv=none; b=Brm8wQWtDUnuMwQVhMKBiGboxWCg2m8KBxFpgmdKlcyyCIIhKrZ6QQA3ggivL4G9aoa+HJMlx8HP64rUewkxCF//dN7xmoSNHm8STL6+M9TMgbIa7y8L/n5PBmr5FTyIfpkwHQfUOoRpQIX435rJFULiRr2SaeVRGdy2SHfG530= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720466804; c=relaxed/simple; bh=yoalBGunsAhVZHpt4Zz+z9F5awaPae/yF3kNbJXTA5Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QVVk0glH04qYw0jsPyrqznvVgRbdQeV4Hiu5QjIHJW7lA2jrtqxIAA9KttRrnqpE7YTUZ3cVElx8PI9Kt9+HSla+loe4Vg/2NToTTDo6B80jYkHUfmgPVLPmB1nJWedA6evZmi5F/9fllcgkr6fAreQ0Czbc01bWHTw5mHlZhGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QqSWUFe4; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QqSWUFe4" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-6e7e23b42c3so2159068a12.1 for ; Mon, 08 Jul 2024 12:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1720466802; x=1721071602; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Emo5pzCrjfNrsol1oVrwdOxe+d/A9gG3XbKfbbvKsdw=; b=QqSWUFe4PRBfxtxoYviLzlWh1Lh0/Uj3Xmqc/pFyUuGNF+k1nvRlgPARyr26MuHxYQ Pr4NUzyJQJvXgvFsr4usoNIqGXg4VAhJcWLdNOcSfEq7YgeYH/mASysQAEd6uAD9QIr3 pMK378Ik9O+pB5k35+pRkAiVvH9rQrJ9FQCeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720466802; x=1721071602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Emo5pzCrjfNrsol1oVrwdOxe+d/A9gG3XbKfbbvKsdw=; b=ByTPEt97C8QSYLXOdlbgKMMLSEl2PV4bbNB/c4R15w43fjj+Hrip5vfMIh0QjctQwg ho78/W6IjL+tbhOd1uaCtYF3GFYxaNe/a17kP6kaM67kiRi2hx3k7//sF3EWuoNeUbjR 7KOgc69b/3tR1rSgLgj/HKXBuEEDrlwwIIuCjU80iegPjSqd47IdXNlQxQ6VyOimzMZ9 LSeP/hbM6WTnjGiKEGbEl+/tnbKgGZQX+kEHEyuvGj23/Fk4lTl3V5ewFEdBzI3YTQvO mlP11Uct/C7Y68uIBWysykIV8kkgbSQoX4YcxIiroRSnbbb7gQMGNJ80/kWOuCTG1rrx gzJg== X-Gm-Message-State: AOJu0YyT+4Bsli1lieioLYkiH7iqvMn0LxQiwak9cEajM/XE4fiQNvMr QqVKEV8xriHku4l79Ioy8HMPDTchSy8iXR+mJue0gPmn1+uRIANEdW5LfBCVqA== X-Google-Smtp-Source: AGHT+IFzWLGpJjfdPjA5LoDyCMlL1inahjNqMJV6Pi2zIPLk2kpujT5ZtrJAD9JSab5j7LYKjxGTVQ== X-Received: by 2002:a05:6a20:1582:b0:1c2:94ad:1c66 with SMTP id adf61e73a8af0-1c2982163d9mr331010637.5.1720466802283; Mon, 08 Jul 2024 12:26:42 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:3e22:9cde:6b65:e5e8]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-1fbb6a10111sm2283585ad.20.2024.07.08.12.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 12:26:41 -0700 (PDT) Date: Mon, 8 Jul 2024 12:26:40 -0700 From: Brian Norris To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com, Francesco Dolcini Subject: Re: [PATCH v11 2/2] wifi: mwifiex: add host mlme for AP mode Message-ID: References: <20240704033001.603419-1-yu-hao.lin@nxp.com> <20240704033001.603419-3-yu-hao.lin@nxp.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704033001.603419-3-yu-hao.lin@nxp.com> Hi David, On Thu, Jul 04, 2024 at 11:30:01AM +0800, David Lin wrote: > Add host based MLME to enable WPA3 functionalities in AP mode. > This feature required a firmware with the corresponding V2 Key API > support. The feature (WPA3) is currently enabled and verified only > on IW416. Also, verified no regression with change when host MLME > is disabled. > > Signed-off-by: David Lin > Reviewed-by: Francesco Dolcini > Acked-by: Brian Norris > --- > > v11: > - modify 'mwifiex_mgmt_stypes' to allow multi-adapters with different > setting of host_mlme_enbaled. ... > - wiphy->mgmt_stypes = mwifiex_mgmt_stypes; > + if (adapter->host_mlme_enabled) { > + memcpy(adapter->mwifiex_mgmt_stypes, > + mwifiex_mgmt_stypes, > + NUM_NL80211_IFTYPES * > + sizeof(struct ieee80211_txrx_stypes)); > + > + adapter->mwifiex_mgmt_stypes[NL80211_IFTYPE_AP].tx = 0xffff; > + adapter->mwifiex_mgmt_stypes[NL80211_IFTYPE_AP].rx = > + BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) | > + BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) | > + BIT(IEEE80211_STYPE_PROBE_REQ >> 4) | > + BIT(IEEE80211_STYPE_DISASSOC >> 4) | > + BIT(IEEE80211_STYPE_AUTH >> 4) | > + BIT(IEEE80211_STYPE_DEAUTH >> 4) | > + BIT(IEEE80211_STYPE_ACTION >> 4); > + wiphy->mgmt_stypes = adapter->mwifiex_mgmt_stypes; > + } else { > + wiphy->mgmt_stypes = mwifiex_mgmt_stypes; > + } > wiphy->max_remain_on_channel_duration = 5000; > wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | > BIT(NL80211_IFTYPE_P2P_CLIENT) | ... > --- a/drivers/net/wireless/marvell/mwifiex/main.h > +++ b/drivers/net/wireless/marvell/mwifiex/main.h > @@ -1008,6 +1008,7 @@ struct mwifiex_adapter { > > bool ext_scan; > bool host_mlme_enabled; > + struct ieee80211_txrx_stypes mwifiex_mgmt_stypes[NUM_NL80211_IFTYPES]; This wasn't exactly what I had in mind by a "second copy" of mwifiex_mgmt_stypes -- that you add a new array to mwifiex_adapter that is only sometimes used. I meant something more like a const 'mwifiex_mgmt_stypes_mlme`, with the appropriate constant values. But I suppose this works too, if a bit awkward, and saves a bit of code/data duplication. So, the 'Acked-by' still seems appropriate. Thanks for the patience on this series. Brian