From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C80E8C3DA41 for ; Mon, 8 Jul 2024 17:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YkusCYNOM/4VTTdq31kjEHT9WtrqZjVDnRly27qO6U4=; b=AHVapo+mjUia0wbZEttW6my1lF 8TNUkA5RaBWwIvPI+gaFfSXC0SNFrCP+fzuC0UR6Ls4rNWpQXGa99NsqN/WTheQOOd6qmFhKThDir MsbP54ojsRHGcsF3r5C7sXmGEo81aZRnI01CXpsaUujNOaILkL7jWKpCA+eiU+W8//57Rfkq87ntl +OVBi9bifUU7BflHjibYZmdCP/HrCMzEQfQRmPgEwNeD4q97BvKx6nG3VHkrXtFS0TVLGCE48oD3/ pD5NMNrmRf2JkntJb9jm7xLRlJ0pR34c6OsdmYgFr/JX737Woyx1fwW/4MlvwwZKjHt/Fa3AJDBCq hH/mI6KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQrtr-00000004Ycq-1xS9; Mon, 08 Jul 2024 17:11:39 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQrsP-00000004XyA-3cBv for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 17:10:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EAF08CE0E26; Mon, 8 Jul 2024 17:10:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA491C4AF0A; Mon, 8 Jul 2024 17:10:04 +0000 (UTC) Date: Mon, 8 Jul 2024 18:10:02 +0100 From: Catalin Marinas To: Beata Michalska Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, vincent.guittot@linaro.org, vanshikonda@os.amperecomputing.com, sumitg@nvidia.com, yang@os.amperecomputing.com, lihuisong@huawei.com, viresh.kumar@linaro.org, rafael@kernel.org Subject: Re: [PATCH v6 0/4] Add support for AArch64 AMUv1-based arch_freq_get_on_cpu Message-ID: References: <20240603082154.3830591-1-beata.michalska@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240603082154.3830591-1-beata.michalska@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_101010_160582_E72518D1 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Beata, On Mon, Jun 03, 2024 at 09:21:50AM +0100, Beata Michalska wrote: > Introducing arm64 specific version of arch_freq_get_on_cpu, cashing on > existing implementation for FIE and AMUv1 support: the frequency scale > factor, updated on each sched tick, serves as a base for retrieving > the frequency for a given CPU, representing an average frequency > reported between the ticks - thus its accuracy is limited. > > The changes have been rather lightly (due to some limitations) tested on > an FVP model. Note that some small discrepancies have been observed while > testing (on the model) and this is currently being investigated, though it > should not have any significant impact on the overall results. What's the plan with this series? Are you still investigating those discrepancies or is it good to go? -- Catalin